Fix: Infinite loop in language server due to not caching indeterminate entities #5940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timotheeguerin
requested review from
bterlson,
markcowl,
allenjzhang,
witemple-msft,
chrisradek and
AlitzelMendez
as code owners
microsoft-github-policy-service
bot
added
the
compiler:core
|
All changed packages have been documented.
Show changes
|
|
You can try these changes here
|
chrisradek
approved these changes
Feb 11, 2025
dmnorc
pushed a commit
to dmnorc/typespec
that referenced
this pull request
Feb 18, 2025
…e entities (microsoft#5940) fix microsoft#2964 The problem is everytime we created an indeterminate entity we created a new object instead of caching it from the type. This meant everytime we needed to reinstantiate the template it would create 2 separate instances. This caused an inifinite loop in the LSP as it would call getTypeForNode for diagnostics This should also solve some duplicate type issue we might have encountered.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #5938
The problem is everytime we created an indeterminate entity we created a new object instead of caching it from the type. This meant everytime we needed to reinstantiate the template it would create 2 separate instances.
This caused an inifinite loop in the LSP as it would call getTypeForNode for diagnostics
This should also solve some duplicate type issue we might have encountered.