feat(compiler): Support ESM subpath imports #5572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Naoki Ikeguchi <[email protected]>
Signed-off-by: Naoki Ikeguchi <[email protected]>
siketyan
requested review from
bterlson,
markcowl,
allenjzhang,
timotheeguerin and
witemple-msft
as code owners
siketyan
changed the title
Co-authored-by: Timothee Guerin <[email protected]>
timotheeguerin
approved these changes
Feb 6, 2025
|
Thank you for picking up this and the follow-up commits 🙏 looking forward to the next release! |
dmnorc
pushed a commit
to dmnorc/typespec
that referenced
this pull request
Feb 18, 2025
In my understand TypeSpec typically follows the ESM module resolution algorithm. Subpath exports are already supported, but subpath imports are not yet. This pull request proposes to add support for ESM subpath imports in TypeSpec files. For details of subpath imports, refer https://nodejs.org/api/packages.html#subpath-imports and https://nodejs.org/api/esm.html#resolution-algorithm-specification. ## Example usage If we have a `imports` declaration in `package.json`: ```json { "name": "@contoso/tsp", "imports": { "#utils": "./src/utils.tsp", }, } ``` We can now import `#utils` from tsp files: ```tsp import "#utils"; ``` --------- Signed-off-by: Naoki Ikeguchi <[email protected]> Co-authored-by: Timothee Guerin <[email protected]> Co-authored-by: Timothee Guerin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my understand TypeSpec typically follows the ESM module resolution algorithm. Subpath exports are already supported, but subpath imports are not yet. This pull request proposes to add support for ESM subpath imports in TypeSpec files.
For details of subpath imports, refer https://nodejs.org/api/packages.html#subpath-imports and https://nodejs.org/api/esm.html#resolution-algorithm-specification.
Example usage
If we have a
importsdeclaration inpackage.json:{ "name": "@contoso/tsp", "imports": { "#utils": "./src/utils.tsp", }, }We can now import
#utilsfrom tsp files: