[typespec-vscode] Make 'convert to object value' code fix recursive #5342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the quick fix of the entire expression can you get the desired result; If you click on the quick fix for a partial expression, because there is no recursive part in the middle of the partial expression, you need to click twice to get the desired result
mzhongl524
requested review from
bterlson,
markcowl,
allenjzhang and
timotheeguerin
as code owners
microsoft-github-policy-service
bot
added
the
compiler:core
|
All changed packages have been documented.
Show changes
|
|
You can try these changes here
|
RodgeFu
reviewed
Dec 17, 2024
packages/compiler/src/core/compiler-code-fixes/model-to-object-literal.codefix.ts
Outdated
Show resolved
Hide resolved
RodgeFu
reviewed
Dec 17, 2024
packages/compiler/src/core/compiler-code-fixes/model-to-object-literal.codefix.ts
Outdated
Show resolved
Hide resolved
RodgeFu
reviewed
Dec 17, 2024
packages/compiler/test/core/compiler-code-fixes/model-to-literal.codefix.test.ts
Outdated
Show resolved
Hide resolved
RodgeFu
changed the title
|
Can this also support converting tuples to value syntax? @example({ Bar: [ {Baz: "Hello"}, [ "foo" ] ] })
// to
@example(#{ Bar: #[ #{Baz: "Hello"}, #[ "foo" ] ] }) |
chrisradek
reviewed
Jan 9, 2025
packages/compiler/test/core/compiler-code-fixes/model-to-literal.codefix.test.ts
Outdated
Show resolved
Hide resolved
timotheeguerin
approved these changes
Jan 21, 2025
.chronus/changes/make-convert-to-objval-codefix-recursive-2024-11-18-5-24-11.md
Outdated
Show resolved
Hide resolved
.chronus/changes/make-convert-to-objval-codefix-recursive-2024-11-18-5-24-11.md
Outdated
Show resolved
Hide resolved
chrisradek
approved these changes
Jan 21, 2025
…-11-18-5-24-11.md Co-authored-by: Timothee Guerin <[email protected]>
…-11-18-5-24-11.md Co-authored-by: Timothee Guerin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix : #4613
There will be two quick fixes for this issue, and only by clicking on the quick fix of the entire expression can you get the desired result; If you click on the quick fix for a partial expression, because there is no recursive part in the middle of the partial expression, you need to click twice to get the desired result