Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve logic of no-routes rule #2673

Merged
merged 4 commits into from
Nov 16, 2023
Merged

Improve logic of no-routes rule #2673

merged 4 commits into from
Nov 16, 2023

Conversation

tjprescott
Copy link
Member

@tjprescott tjprescott commented Nov 15, 2023 •
edited
Loading

Fix #2573.

Playground shows that:

  • the warning now appears on any namespace that has operations if none have @service
  • does not appear when there are operations in the global namespace
  • disappears from all namespaces when @service is placed on any namespace that has operations

@github-actions GitHub Actions
Copy link
Contributor

Changes in this PR will be published to the following url to try(check status of TypeSpec Pull Request Try It pipeline for publish status):
Playground: https://cadlplayground.z22.web.core.windows.net/prs/2673/

Website: https://tspwebsitepr.z22.web.core.windows.net/prs/2673/

@tjprescott tjprescott marked this pull request as ready for review November 16, 2023 16:50
timotheeguerin
timotheeguerin approved these changes Nov 16, 2023
View reviewed changes
Copy link
Member

@timotheeguerin timotheeguerin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one little nit on the function

@tjprescott tjprescott enabled auto-merge (squash) November 16, 2023 21:37
@tjprescott tjprescott merged commit 324fdc3 into microsoft:main Nov 16, 2023
10 checks passed
@tjprescott tjprescott deleted the http/FixNoRoutes branch November 16, 2023 21:57
@timotheeguerin timotheeguerin mentioned this pull request Nov 17, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daviwil daviwil daviwil left review comments

@timotheeguerin timotheeguerin timotheeguerin approved these changes

@bterlson bterlson Awaiting requested review from bterlson bterlson is a code owner

@markcowl markcowl Awaiting requested review from markcowl markcowl is a code owner

@allenjzhang allenjzhang Awaiting requested review from allenjzhang allenjzhang is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Provide a suppression mechanism for @typespec/http/no-routes
3 participants
@tjprescott @daviwil @timotheeguerin