Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Json Schema Fix: 0 value in an enum would cause the enum type to be string and number #2658

Merged
merged 3 commits into from
Nov 13, 2023
Merged

Json Schema Fix: 0 value in an enum would cause the enum type to be string and number #2658

merged 3 commits into from
Nov 13, 2023

Conversation

timotheeguerin
Copy link
Member

fix #2538

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 9, 2023

Changes in this PR will be published to the following url to try(check status of TypeSpec Pull Request Try It pipeline for publish status):
Playground: https://cadlplayground.z22.web.core.windows.net/prs/2658/

Website: https://tspwebsitepr.z22.web.core.windows.net/prs/2658/

@timotheeguerin timotheeguerin enabled auto-merge (squash) November 13, 2023 22:51
@timotheeguerin timotheeguerin merged commit 797baa8 into microsoft:main Nov 13, 2023
10 checks passed
@timotheeguerin timotheeguerin deleted the fix/enum-0-string branch November 13, 2023 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tjprescott tjprescott tjprescott approved these changes

@bterlson bterlson Awaiting requested review from bterlson bterlson is a code owner

@daviwil daviwil Awaiting requested review from daviwil

@markcowl markcowl Awaiting requested review from markcowl markcowl is a code owner

@allenjzhang allenjzhang Awaiting requested review from allenjzhang allenjzhang is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Json Schema emitter add type of enum is string when there is 0 as an option
2 participants
@timotheeguerin @tjprescott