Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with Body<T> missing @doc #2332

Merged
merged 1 commit into from
Aug 28, 2023
Merged

Conversation

tjprescott
Copy link
Member

Fixes #2238.

@github-actions
Copy link
Contributor

Changes in this PR will be published to the following url to try(check status of TypeSpec Pull Request Try It pipeline for publish status):
Playground: https://cadlplayground.z22.web.core.windows.net/prs/2332/

Website: https://cadlwebsite.z1.web.core.windows.net/prs/2332/

packages/http/lib/http.tsp Outdated Show resolved Hide resolved
@@ -517,6 +517,7 @@ describe("openapi3: metadata", () => {
},
},
requestBody: {
description: "The body.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might need to send a comparable PR on the typespec-azure side too because Body<T> may be used in Azure Core

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tjprescott tjprescott merged commit c2a906b into microsoft:main Aug 28, 2023
12 checks passed
@tjprescott tjprescott deleted the bodyTDoc branch August 28, 2023 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Body model in typespec.http results in warning due to missing doc decorator
2 participants