Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Implementation] Allow trailing list delimiter everywhere #809

Closed
nguerrera opened this issue Aug 3, 2022 · 1 comment · Fixed by #4837
Closed

[Implementation] Allow trailing list delimiter everywhere #809

nguerrera opened this issue Aug 3, 2022 · 1 comment · Fixed by #4837
Assignees
@timotheeguerin
Milestone
Backlog

Comments

@nguerrera
Copy link
Contributor

nguerrera commented Aug 3, 2022 •
edited
Loading

Implementation issue for #789

  • Delete trailingDelimiterIsValid, and behave as though it was always true.
  • Add parser tests for all cases.
  • Add formatter tests for all cases.
  • Update language grammar

Demonstration of current places where trailing delimiter is not allowed, but would become allowed with this change:

Playground Link

(Model properties and interface members are also OK today, but not shown.)
@ghost ghost added the Needs Triage label Aug 3, 2022
@nguerrera nguerrera mentioned this issue Aug 3, 2022
Closed
@markcowl
Copy link
Contributor

markcowl commented Aug 5, 2022 •
edited
Loading

estimate: 3, priority: 2

@markcowl markcowl added this to the [2022] September milestone Aug 5, 2022
@markcowl markcowl added 📌 and removed Needs Triage labels Aug 5, 2022
@markcowl markcowl modified the milestones: [2023] January, [2023] March Dec 5, 2022
@markcowl markcowl modified the milestones: [2023] March, [2023] April Jan 11, 2023
@markcowl markcowl modified the milestones: [2023] April, [2023] May Jan 28, 2023
@markcowl markcowl modified the milestones: [2023] May, Backlog Feb 9, 2023
@timotheeguerin timotheeguerin mentioned this issue Oct 23, 2024
Merged
@timotheeguerin timotheeguerin self-assigned this Oct 23, 2024
github-merge-queue bot pushed a commit that referenced this issue Nov 21, 2024
@timotheeguerin
Allow trailing delimited in most locations (#4837)
8afd0e8 
fix #2284 
fix #809

Extracted the parser change from pr #4372 and made it more generic to
cover also issue #809
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@timotheeguerin timotheeguerin

Labels
None yet
Projects
None yet
Milestone
Backlog
Development

Successfully merging a pull request may close this issue.

Allow trailing delimited in most locations timotheeguerin/typespec
4 participants
@bterlson @nguerrera @timotheeguerin @markcowl