Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[http-server-csharp] operations with normal response and error response is generated to return JsonNode #5222

Closed
ArcturusZhang opened this issue Nov 29, 2024 · 1 comment

Comments

@ArcturusZhang
Copy link
Member

In todoApp, we have this operation:

  @get op get(@path id: TodoItem.id): TodoItem | NotFoundResponse;

but the generated operation for this is:

    public interface ITodoItemsOperations
    {
        Task<JsonNode> GetAsync(long id);
    }

which is not a really good API.
Other operations are returning the WithStandardErrors<T | NotFoundResponse> but they work fine.

@markcowl
Copy link
Contributor

markcowl commented Dec 2, 2024

This is about rendering of unions, which we are handlign with a separate issue: #5179

@markcowl markcowl closed this as completed Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants