Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Unbranded Client CodeGen] Emitters should ignore the unsupported authentication #5207

Open
6 tasks done
lirenhe opened this issue Nov 27, 2024 · 4 comments
Open
6 tasks done
Labels
1_0_E2E emitter:client:csharp Issue for the C# client emitter: @typespec/http-client-csharp emitter:client:java Issue for the Java client emitter: @typespec/http-client-java emitter:client:python Issue for the Python client emitter: @typespec/http-client-python epic

Comments

@lirenhe
Copy link
Member

lirenhe commented Nov 27, 2024

Clear and concise description of the problem

We need to ignore the unsupported authentication defined in TypeSpec instead of generating incorrect code.
There is no plan to update the spec to remove those authentications.

Tasks

Preview Give feedback
  1. tadelesh
  2. emitter:client:java
  3. HRLC non-azure p0
    MaryGao
  4. emitter:client:csharp
    JoshLove-msft
  5. emitter:client:csharp
  6. emitter:client:csharp
    jorgerangel-msft

Checklist

  • Follow our Code of Conduct
  • Read the docs.
  • Check that there isn't already an issue that request the same feature to avoid creating a duplicate.
@lirenhe lirenhe added 1_0_E2E emitter:client:csharp Issue for the C# client emitter: @typespec/http-client-csharp emitter:client:java Issue for the Java client emitter: @typespec/http-client-java emitter:client:python Issue for the Python client emitter: @typespec/http-client-python epic labels Nov 27, 2024
@ArcturusZhang
Copy link
Member

I kind of think the Ignore in the title is inappropriate - we should never "ignore" something, this is not a correct behavior.
Instead, we should not panic or crash when we met into something we cannot recognize.

@jsquire
Copy link
Member

jsquire commented Dec 11, 2024

@lirenhe: I need this issue rescoped or a new one filed for C#, as it is not actionable in this form. We will need:

  • A clear description of the problem that we're trying to solve. What are the troublesome scenarios? What is the experience that we're trying to offer? What is the scope of the problem?

  • Something that identifies workstream this request is associated with. I believe this one is related to the VSCode extension, but that is just my assumption as that information is not available.

  • Who are the stakeholders asking for this? We'll need to be able to work with them for additional information and to set expectations.

  • What is the requested priority to associate with this?

  • What is the requested timeframe for this? What does it block if it does not meet that requested timeframe?

We'll need the same information for all of the asks on the C# emitter in order to prioritize, resource plan, and execute.

//fyi: @JoshLove-msft, @m-nash, @ArthurMa1978, @lmazuel, @schaabs

@lmazuel
Copy link
Member

lmazuel commented Dec 18, 2024

@jsquire

@lirenhe
Copy link
Member Author

lirenhe commented Dec 25, 2024

@jsquire, I created a separate issue for .NET here. #5355

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1_0_E2E emitter:client:csharp Issue for the C# client emitter: @typespec/http-client-csharp emitter:client:java Issue for the Java client emitter: @typespec/http-client-java emitter:client:python Issue for the Python client emitter: @typespec/http-client-python epic
Projects
None yet
Development

No branches or pull requests

4 participants