Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Unbranded Client CodeGen] Support basic visibility handling in client library code generation #5205

Closed
1 task done
lirenhe opened this issue Nov 27, 2024 · 4 comments
Closed
1 task done
Labels
1_0_E2E emitter:client:csharp Issue for the C# client emitter: @typespec/http-client-csharp emitter:client:java Issue for the Java client emitter: @typespec/http-client-java emitter:client:python Issue for the Python client emitter: @typespec/http-client-python epic

Comments

@lirenhe
Copy link
Member

lirenhe commented Nov 27, 2024

Clear and concise description of the problem

Based on the discussion, currently we agree on

  1. Ignore any handling for visibility('create')
  2. Visibility none, we should delete the property

More tasks will be added if we found challenges for supporting other kind of visibility.

Actions

Preview Give feedback
  1. lib:tcgc
    tadelesh

Checklist

  • Follow our Code of Conduct
  • Read the docs.
  • Check that there isn't already an issue that request the same feature to avoid creating a duplicate.
@lirenhe lirenhe changed the title [Unbranded Client CodeGen] Support visibility in client library code generation [Unbranded Client CodeGen] Support basic visibility handling in client library code generation Nov 27, 2024
@lirenhe lirenhe added emitter:client:csharp Issue for the C# client emitter: @typespec/http-client-csharp emitter:client:java Issue for the Java client emitter: @typespec/http-client-java emitter:client:python Issue for the Python client emitter: @typespec/http-client-python labels Nov 27, 2024
@JoshLove-msft
Copy link
Contributor

@lirenhe, can you clarify what is meant by

Ignore any handling for visibility('create')

For .NET, we were thinking of handling visibility as outlined in #5175

@lirenhe
Copy link
Member Author

lirenhe commented Dec 9, 2024

@lirenhe, can you clarify what is meant by

Ignore any handling for visibility('create')

For .NET, we were thinking of handling visibility as outlined in #5175

@JoshLove-msft, If we take the generated code of .NET from TypeSpec-ToDo today, https://github.com/allenjzhang/typespec-e2e-demo/blob/main/todoApp/spec/main.tsp

There is a model of 'CreateResponse1' as part of the SDK.

https://github.com/allenjzhang/typespec-e2e-demo/blob/05c4c8d01281d4e1d2167e889c45b68000fd3492/todoApp/clients/dotnet/src/Generated/Users.cs#L82

Based on my conversation with @lmazuel, fix naming issue introduced by visibility('create') is considered as low priority for TypeSpec E2E experience. Also it won't impact any of your design around visibility.

Please let me know if you have further questions. thanks

@lmazuel
Copy link
Member

lmazuel commented Dec 12, 2024

@lirenhe I want to close that issue, here's why:

  • create and none should be two issues
  • create is out of scope for E2E
  • none has been fixed in TCGC 0.48.3

@lirenhe
Copy link
Member Author

lirenhe commented Dec 12, 2024

Close this item as all language verified 'none' has been fixed.

@lirenhe lirenhe closed this as completed Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1_0_E2E emitter:client:csharp Issue for the C# client emitter: @typespec/http-client-csharp emitter:client:java Issue for the Java client emitter: @typespec/http-client-java emitter:client:python Issue for the Python client emitter: @typespec/http-client-python epic
Projects
None yet
Development

No branches or pull requests

3 participants