Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Augment decorator not working on properties coming from model is #2867

Closed
timotheeguerin opened this issue Jan 31, 2024 · 1 comment · Fixed by #4849
Closed

Augment decorator not working on properties coming from model is #2867

timotheeguerin opened this issue Jan 31, 2024 · 1 comment · Fixed by #4849
Assignees
@timotheeguerin
Labels
compiler:core Issues for @typespec/compiler triaged:core
Milestone
[2024] November

Comments

@timotheeguerin
Copy link
Member

timotheeguerin commented Jan 31, 2024 •
edited
Loading 

model Foo {
  @doc("Base doc")
  name: string;
}

model Bar is Foo {}

@@doc(Bar.name, "Override bar");

Playground Link
@mgl1969 mgl1969 mentioned this issue Jan 31, 2024
Merged
4 tasks
@markcowl markcowl added this to the Backlog milestone Feb 5, 2024
@markcowl
Copy link
Contributor

markcowl commented Feb 5, 2024

@bterlson Is there a chance the symbol refactor will fix this?

@timotheeguerin timotheeguerin mentioned this issue Oct 29, 2024
Merged
@timotheeguerin timotheeguerin self-assigned this Oct 29, 2024
@timotheeguerin timotheeguerin added the compiler:core Issues for @typespec/compiler label Oct 29, 2024
github-merge-queue bot pushed a commit that referenced this issue Nov 5, 2024
@timotheeguerin @bterlson
Symbol refactor (#4849)
b39abe5 
### Augment decorator issues
Fix #4749 Augment/ref alias
properties
Fix #2867 Augment/ref `model
is` properties
Fix #4818 Augment/ref nested
model properties

### Circular reference issues
Fix #4908 freeze when using
circular model extends with aliases

### Others
FIx #4915 (Duplicate usings
not scoped per namespace)

Doesn't resolve the alias circular issue
#2824 but I think setup the
solution for fixing it later in the name resolver where we could detect
that cycle instead of the checker

---------

Co-authored-by: Brian Terlson <[email protected]>
swatkatz pushed a commit to swatkatz/typespec that referenced this issue Nov 5, 2024
@timotheeguerin @bterlson
Symbol refactor (microsoft#4849)
df232e8 
### Augment decorator issues
Fix microsoft#4749 Augment/ref alias
properties
Fix microsoft#2867 Augment/ref `model
is` properties
Fix microsoft#4818 Augment/ref nested
model properties

### Circular reference issues
Fix microsoft#4908 freeze when using
circular model extends with aliases

### Others
FIx microsoft#4915 (Duplicate usings
not scoped per namespace)

Doesn't resolve the alias circular issue
microsoft#2824 but I think setup the
solution for fixing it later in the name resolver where we could detect
that cycle instead of the checker

---------

Co-authored-by: Brian Terlson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@timotheeguerin timotheeguerin

Labels
compiler:core Issues for @typespec/compiler triaged:core
Projects
None yet
Milestone
[2024] November
Development

Successfully merging a pull request may close this issue.

Symbol refactor timotheeguerin/typespec
2 participants
@timotheeguerin @markcowl