Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: allow ts-style-plugin configuration #36

Open
paullewis opened this issue Mar 18, 2021 · 0 comments
Open

Feature request: allow ts-style-plugin configuration #36

paullewis opened this issue Mar 18, 2021 · 0 comments

Comments

@paullewis
Copy link

paullewis commented Mar 18, 2021

Firstly, thanks for your work on this plugin, it's great to be able to have syntax highlighting and Intellisense for template strings :) I've noticed, though, that ts-styled-plugin gets rather upset (Do not use empty rulesets: ts-styled-plugin(9999)) if there's a style attribute that is populated by a Lit styleMap Directive, i.e.,

<div style=${styleMap(styles}}></div>

While I appreciate the primary issue is upstream in ts-styled-plugin, there is no way when using this plugin to configure it such that it ignores – say – empty style rules, which I would be able to set were I configuring the plugin directly. I think it comes down to https://github.com/microsoft/typescript-lit-html-plugin/blob/main/src/index.ts#L50, which I think is passing through an empty config to ts-styled-plugin.

I was wondering, would it be possible to either take extra config for ts-styled-plugin, or use any relevant global configs rather than setting it to {}?

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant