"exports" field named exports support #121
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 16, 2020
| "import": "./tslib.es6.js", | ||
| "default": "./tslib.js" | ||
| }, | ||
| "./": "./" |
There was a problem hiding this comment.
Do we need this one? What will break if we don't include it?
There was a problem hiding this comment.
This is mostly for require.resolve use cases and exactly makes this backwards compatible. For example:
require.resolve('tslib/tslib.d.ts')require.resolve('tslib/package.json')require.resolve('tslib/tslib.es6.js')require('tslib/tslib.js')
|
This is now in with #126 - thanks for the feedback Guy! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many packages use patterns like
import { __assign } from 'tslib'which breaks down in Node.js and environments that provide Node.js-style CommonJS interop.Using the "exports" field we can ensure that ES importers get the expected shape with named exports.
//cc @weswigham @DanielRosenwasser