Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FCSiam tests require internet access #495

Closed
adamjstewart opened this issue Apr 3, 2022 · 1 comment · Fixed by #497
Closed

FCSiam tests require internet access #495

adamjstewart opened this issue Apr 3, 2022 · 1 comment · Fixed by #497
Labels
testing Continuous integration testing
Milestone

Comments

@adamjstewart
Copy link
Collaborator

The FCSiam tests have been intermittently failing in CI when an SSL certificate is expired or a runner loses internet connection. @calebrob6 can you work your magic on this like you did in #265? I'm guessing this was introduced during the refactor in #345.

Steps to Reproduce

  1. Turn off WiFi on your laptop
  2. Run pytest tests/models/test_fcsiam.py

I confirmed that only test_fcsiam.py is affected, no other datasets or models require internet access.

P.S. The file it's trying to download is https://download.pytorch.org/models/resnet34-333f7ec4.pth if that helps narrow it down.

@adamjstewart adamjstewart added the testing Continuous integration testing label Apr 3, 2022
@adamjstewart adamjstewart added this to the 0.3.0 milestone Apr 3, 2022
@isaaccorley
Copy link
Collaborator

I think all that needs to be changed is that we pass encoder_weights=None to the models in the tests. I'll make a quick PR for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing Continuous integration testing
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants