Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FAIR1M Dataset labels_root name #1098

Closed
SpontaneousDuck opened this issue Feb 8, 2023 · 0 comments · Fixed by #1099
Closed

FAIR1M Dataset labels_root name #1098

SpontaneousDuck opened this issue Feb 8, 2023 · 0 comments · Fixed by #1099
Labels
datasets Geospatial or benchmark datasets
Milestone

Comments

@SpontaneousDuck
Copy link
Contributor

SpontaneousDuck commented Feb 8, 2023

Description

I just downloaded the FAIR1M dataset and found that the labelXmls.zip files extract to a folder named labelXml instead of the folder expected by torchgeo.datasets.FAIR1M shown below.

labels_root: str = "labelXmls"

I can get around this by extracting to the expected folder myself but this is not how the zip extracts by default. Did this maybe change recently in the dataset?

Steps to reproduce

  1. Download FAIR1M dataset from the Google Drive on their website (https://www.gaofen-challenge.com/benchmark)
  2. Create dataset object
from torchgeo.datasets import FAIR1M
ds = FAIR1M(root='/data/FAIR1M/train/part2')
  1. Check data root and see the folder name mismatch. This occurs in all the data folders.
$ ls /data/FAIR1M/train/part2
images  images.zip  labelXml  labelXmls.zip
$ ls /data/FAIR1M/train/part1
images  images.zip  labelXml  labelXmls.zip
$ ls /data/FAIR1M/validation
images  images.zip  labelXml  labelXmls.zip

Version

0.4.0

@adamjstewart adamjstewart added this to the 0.4.1 milestone Feb 9, 2023
@adamjstewart adamjstewart added the datasets Geospatial or benchmark datasets label Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
datasets Geospatial or benchmark datasets
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants