Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch 3.6.2 breaks build for non-English locales #4006

Closed
LaurentTreguier opened this issue Nov 5, 2024 · 2 comments · Fixed by #4012
Closed

Patch 3.6.2 breaks build for non-English locales #4006

LaurentTreguier opened this issue Nov 5, 2024 · 2 comments · Fixed by #4012

Comments

@LaurentTreguier
Copy link

Describe the bug

Using MSTest.Adapter and MSTest.TestFramework at version 3.6.2

Steps To Reproduce

  1. Use a non-English locale (for example, French)
  2. Create a new WinUI 3 project in Visual Studio
  3. Add a test project to the solution
  4. Update the test project's dependencies to the latest versions
  5. Try to build and run the tests

Expected behavior

The project should build and execute the example test cases.

Actual behavior

The build fails with APPX1101; multiple DLLs are duplicated between MSTest.Adapter and MSTest.TestFramework.

Additional context

The key to the problem seems to be the system locale. All of the duplicated DLL files during my testing were under fr subdirectories, found inside for example the mstest.testadapter\3.6.2\build\_localization and mstest.testframework\3.6.2\lib\net8.0 directories. Those do not contain anything for English locales, hence why the issue doesn't seem to arise on a system with an English locale set.

@nohwnd
Copy link
Member

nohwnd commented Nov 6, 2024

Thanks for reporting, this is most likely related to this change that fixed copying the resource files, they were not copied properly before. #3949

And caused by the filter in this change #3874 not being strict enough. It should most likely not copy the Framework or ObjectModel dlls.

@nohwnd
Copy link
Member

nohwnd commented Nov 6, 2024

#3874 is not on 3.6 at all, backporting and fixing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants