-
Notifications
You must be signed in to change notification settings - Fork 260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set encoding in console to UTF8 #2491
Comments
I don't think it's a bug...we don't do nothing and we use the default of the platform. I think that the adapter should take this responsibility as platform we don't own or know nothing about "what" the plugged testing platform does...it could not send messages to the output device at all. Another idea can be if we think that's a good "default" for our default console "set by default" utf-8 and provide some "command line args" to change it to something else like '--console-output-encoding xxx' Waiting for @Evangelink thought |
Haven't put much thoughts but this seems the best. A "good" default and an easy way to change it. I don't know how busy is the sprint but if there is some room for it, I would try to work on it for 3.4 (not sure if you already did the feature complete preview release for 3.3). |
I don't think this can be purely testing framework concern. The encoding needs to align with msbuild integration for dotnet test, if we want to transport the standard output data correctly, otherwise we are losing encoding and information. This is not so painful for english speaking countries, where utf-8 is mostly used in form of emojis that are rarely used in test names and output, but without this we will be breaking chinese and other characters. |
Yep, this needs to be followed also for "custom" possible output display in case. |
Seems like having an option to change the encoding and having |
Describe the bug
Frameworks or users might use utf8 characters in their output messages. Set console encoding to utf8 (as we do in vstest.console, and as xunit.console does). microsoft/vstest#4605
Optionally put this under environment variable feature flag.
Steps To Reproduce
mstest108.zip
Expected behavior
I can see the smileys.
Actual behavior
I see ??
Additional context
The text was updated successfully, but these errors were encountered: