Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AWS Service Endpoint resource #58

Merged
merged 5 commits into from
Jul 14, 2020
Merged

Add AWS Service Endpoint resource #58

merged 5 commits into from
Jul 14, 2020

Conversation

phillebaba
Copy link
Contributor

All Submissions:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My code follows the code style of this project.
  • I ran lint checks locally prior to submission.
  • Have you checked to ensure there aren't other open PRs for the same update/change?

What about the current behavior has changed?

This change adds the resource azuredevops_serviceendpoint_aws that configures the Service Endpoint added by [aws-toolkit-azure-devops](https://githu

Issue Number: #48

Does this introduce a change to go.mod, go.sum or vendor/?

  • Yes
  • No

Does this introduce a breaking change?

  • Yes
  • No

Any relevant logs, error output, etc?

(If it’s long, please paste to https://ghostbin.com/ and insert the link here.)

Other information

@phillebaba
Copy link
Contributor Author

Hopefully my new changes will fix all of the issues.

@ghost ghost removed the waiting-response label Jul 14, 2020
Copy link
Collaborator

@xuzhang3 xuzhang3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @phillebaba LGTM.

@xuzhang3 xuzhang3 merged commit 7bf07d3 into microsoft:master Jul 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants