diff --git a/src/cascadia/LocalTests_TerminalApp/TabTests.cpp b/src/cascadia/LocalTests_TerminalApp/TabTests.cpp index df9edfa698e..9141c77b157 100644 --- a/src/cascadia/LocalTests_TerminalApp/TabTests.cpp +++ b/src/cascadia/LocalTests_TerminalApp/TabTests.cpp @@ -954,6 +954,10 @@ namespace TerminalAppLocalTests void TabTests::TestWindowRenameSuccessful() { + BEGIN_TEST_METHOD_PROPERTIES() + TEST_METHOD_PROPERTY(L"IsolationLevel", L"Method") + END_TEST_METHOD_PROPERTIES() + auto page = _commonSetup(); page->RenameWindowRequested([&page](auto&&, const winrt::TerminalApp::RenameWindowRequestedArgs args) { // In the real terminal, this would bounce up to the monarch and @@ -980,6 +984,10 @@ namespace TerminalAppLocalTests } void TabTests::TestWindowRenameFailure() { + BEGIN_TEST_METHOD_PROPERTIES() + TEST_METHOD_PROPERTY(L"IsolationLevel", L"Method") + END_TEST_METHOD_PROPERTIES() + auto page = _commonSetup(); page->RenameWindowRequested([&page](auto&&, auto&&) { // In the real terminal, this would bounce up to the monarch and diff --git a/src/cascadia/TerminalApp/TerminalPage.cpp b/src/cascadia/TerminalApp/TerminalPage.cpp index 20dec5e9227..2ce671f309f 100644 --- a/src/cascadia/TerminalApp/TerminalPage.cpp +++ b/src/cascadia/TerminalApp/TerminalPage.cpp @@ -2708,8 +2708,12 @@ namespace winrt::TerminalApp::implementation void TerminalPage::_RequestWindowRename(const winrt::hstring& newName) { auto request = winrt::make(newName); - // The WindowRenamer is _not_ a Toast - we want it to stay open until the user dismisses it. - WindowRenamer().IsOpen(false); + // The WindowRenamer is _not_ a Toast - we want it to stay open until + // the user dismisses it. + if (WindowRenamer()) + { + WindowRenamer().IsOpen(false); + } _RenameWindowRequestedHandlers(*this, request); // We can't just use request.Successful here, because the handler might // (will) be handling this asynchronously, so when control returns to