Hiding a command by setting its name to null doesn't work properly

[DHowett]

The documentation here states that assigning the value null to an action's "name" field will remove it from the command palette. As of version 1.4.3141.0 (the latest stable release at this writing), following these instructions has no discernible effect.
from @atimholt

Hmm. @carlos-zamora did we break some nullable settings in 1.4? This is before the JsonUtils changes in 1.5...
We should make sure we have tests covering this.
from @DHowett

From MicrosoftDocs/terminal#189

[Don-Vito]

@zadjii-msft - where was this filtering initially? During deserialization, or somewhere later on (in TerminalPage or Palette itself)?

[carlos-zamora]

Oh man. I completely missed responding to this in the docs repo. My bad!

@Don-Vito If you want to take a closer look at this, I'd guess the following places might be a good start:

• GlobalAppSettings::LayerJson() - we take the json and update our KeyMapping (link)
• KeyMapping::LayerJson() - we update our keymapping with each command/action (link)

[DHowett]

It is less likely that this is related to key bindings and more likely that it is related to not-key-bindings.

[Don-Vito]

Oh man. I completely missed responding to this in the docs repo. My bad!

@Don-Vito If you want to take a closer look at this, I'd guess the following places might be a good start:

* `GlobalAppSettings::LayerJson()` - we take the json and update our KeyMapping ([link](https://github.com/microsoft/terminal/blob/8d26f452784cead9fdc353211d3d66d7c27f1fc9/src/cascadia/TerminalSettingsModel/GlobalAppSettings.cpp#L305))

* `KeyMapping::LayerJson()` - we update our keymapping with each command/action ([link](https://github.com/microsoft/terminal/blob/8d26f452784cead9fdc353211d3d66d7c27f1fc9/src/cascadia/TerminalSettingsModel/KeyMappingSerialization.cpp#L95))

@carlos-zamora - yep.. I looked there earlier today.. but didn't find any special treatment for name equals null.. neither in the latest version nor in the previous version.. so I was wondering if I am looking at the correct place or the filtering out done somewhere later on.

[Don-Vito]

@zadjii-msft , @carlos-zamora - on the de-serialization level I see a special handling for null only for action name, and not command name as appears in documentation.
I looked in the history as well.. but didn't find any reference to command name even in the first commit that the palette was introduced. Any chance that the filtering was somewhere else?

[DHowett]

So, the hiding probably happens when we request the name and it comes back as null, rather than during deserialization.

[Don-Vito]

So, the hiding probably happens when we request the name and it comes back as null, rather than during deserialization.

When we request the name it might be too late to hide, because at this stage if the "name" didn't exist we will use the one generated from the args. I consider to take an older release and debug it. I just wondered if @zadjii-msft could possibly remember where this filtering was.

[Don-Vito]

@DHowett - apparently it is a duplicate of #7441 from August. I suggest to track that task and close this one.

[zadjii-msft]

Hey good call! Thanks for helping clean up the repo.

/dup #7441

[ghost]

Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!