Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tab key triggers twice in shell #7598

Closed
dgliwka opened this issue Sep 10, 2020 · 8 comments
Closed

Tab key triggers twice in shell #7598

dgliwka opened this issue Sep 10, 2020 · 8 comments
Labels
Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Resolution-External For issues that are outside this codebase Resolution-Won't-Fix We're just really obstinate about this. There's probably a good reason.

Comments

@dgliwka
Copy link

dgliwka commented Sep 10, 2020

Environment

Windows build number: Microsoft Windows [Version 10.0.19041.508]

Windows Terminal version (if applicable): 1.3.2382.0

Steps to reproduce

  1. Start either cmd, PowerShell or wsl (Ubuntu 20.04) profile (with default settings.json).
  2. Hit Tab ↹ button.
  3. Tab ↹ action is executed by shell twice,

Expected behavior

Shell receives Tab key once, and therefore executes it's action once.

Actual behavior

Shell (bash on wsl, PowerShell or cmd) executes Tab key twice, resulting with two \t characters in vim, or advancing shell's directory autocompletion by two directories.

Notes:

  1. After mapping another key to Tab input code with:
    { "command": { "action": "sendInput", "input": "\u0009" }, "keys": "f2" }
    F2 key sends Tab's input code only once.
  2. It is not a problem with keyboard, as the problem appears only in Windows Terminal.
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Sep 10, 2020
@DHowett
Copy link
Member

DHowett commented Sep 10, 2020

Interesting. Are you using a physical or virtual keyboard? What layout is it?

@DHowett DHowett added the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Sep 10, 2020
@DHowett
Copy link
Member

DHowett commented Sep 10, 2020

(I ask because this doesn't seem to reproduce with US (QWERTY) hardware keyboards for anyone on the team.)

@dgliwka
Copy link
Author

dgliwka commented Sep 10, 2020

It's physical keyboard.
I am using Polish layout, but the problem appears also with English US and UK layout.
Also tried to change system language to English UK, but it did not help.

@ghost ghost added Needs-Attention The core contributors need to come back around and look at this ASAP. and removed Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something labels Sep 10, 2020
@zadjii-msft
Copy link
Member

By any chance, did you try the workaround earlier in #4448, with setting InputServiceEnabled: 1?

@zadjii-msft zadjii-msft added Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something and removed Needs-Attention The core contributors need to come back around and look at this ASAP. labels Sep 11, 2020
@dgliwka
Copy link
Author

dgliwka commented Sep 11, 2020

InputServiceEnabled: 1 does not help. Actually after setting this, keyboard stops working at all for Microsoft Terminal, but not for other programs.

@ghost ghost added Needs-Attention The core contributors need to come back around and look at this ASAP. and removed Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something labels Sep 11, 2020
@DHowett
Copy link
Member

DHowett commented Sep 14, 2020

Sorry, I do not understand.

InputServiceEnabled: 1 is the default, but you need to enable the "Touch Keyboard and Handwriting Panel Service" service. When you have InputServiceEnabled: 1 and service started, does the keyboard continue working for Terminal?

If so, does the Tab bug still happen?

@DHowett DHowett added Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something and removed Needs-Attention The core contributors need to come back around and look at this ASAP. labels Sep 14, 2020
@dgliwka
Copy link
Author

dgliwka commented Sep 15, 2020

Thank you for clarification. It solved the issue.

So for anyone in the future setting

HKLM\SOFTWARE\Microsoft\Input:
  InputServiceEnabled: 1
  InputServiceEnabledForCCI: 1

and setting service Touch Keyboard and Handwriting Panel to manual solves the problem.

@ghost ghost added Needs-Attention The core contributors need to come back around and look at this ASAP. and removed Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something labels Sep 15, 2020
@DHowett
Copy link
Member

DHowett commented Sep 15, 2020

Thanks.

I will add this to the list of issues caused by disabling random windows services!

@DHowett DHowett closed this as completed Sep 15, 2020
@DHowett DHowett added Resolution-External For issues that are outside this codebase Resolution-Won't-Fix We're just really obstinate about this. There's probably a good reason. and removed Needs-Attention The core contributors need to come back around and look at this ASAP. labels Sep 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Resolution-External For issues that are outside this codebase Resolution-Won't-Fix We're just really obstinate about this. There's probably a good reason.
Projects
None yet
Development

No branches or pull requests

3 participants