Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Font size does not match the settings in default Powershell #6797

Closed
kneelesh48 opened this issue Jul 6, 2020 · 7 comments
Closed

Font size does not match the settings in default Powershell #6797

kneelesh48 opened this issue Jul 6, 2020 · 7 comments
Labels
Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.

Comments

@kneelesh48
Copy link

Description of the new feature/enhancement

My laptop has a 15.6" 1920px1080p display.
I'm using font Consolas at size 16 in the default PowerShell and that has been the perfect size for my use.

But Windows Terminal font size does not match PowerShell. So I'm using font Consolas at size 11 in WT. Which is a bit bigger than Consolas at size 16 in default PowerShell and size 10 is a little too small.

This is the only reason I keep switching to default PowerShell. Some terminal outputs don't fit like they should in WT on font Consolas at size 11 and size 10 is too small to read. In my specific case, the command is docker ps -a.

Proposed technical implementation details

I propose using the same font sizes as in the default PowerShell. Might be easier to implement than writing a new sizing scheme.

@kneelesh48 kneelesh48 added the Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. label Jul 6, 2020
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Jul 6, 2020
@DHowett
Copy link
Member

DHowett commented Jul 6, 2020

The traditional win32 console host measures fonts in pixel sizes. Unfortunately, we're not going to be changing either system to align with the other. The one the console host used was old and wrong and bad, and the one WT uses is in line with all other applications.
Somebody recently asked for fractional font sizes, so I'm going to close this one out as a /dupe of #6678. That would help with the issue where 10 is too small and 11 is too large.

@ghost
Copy link

ghost commented Jul 6, 2020

Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!

@ghost ghost closed this as completed Jul 6, 2020
@ghost ghost added Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing. and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Jul 6, 2020
@SharakPL
Copy link

The traditional win32 console host measures fonts in pixel sizes. Unfortunately, we're not going to be changing either system to align with the other. The one the console host used was old and wrong and bad, and the one WT uses is in line with all other applications. Somebody recently asked for fractional font sizes, so I'm going to close this one out as a /dupe of #6678. That would help with the issue where 10 is too small and 11 is too large.

@DHowett are you sure about that? Looks to me Terminal font size are a lot bigger than they should be. For example here's the Cascadia Mono PL at the same font size on:

Windows Terminal
obraz

Visual Studio Code
obraz

Both apps have the same default zoom level.

@DHowett
Copy link
Member

DHowett commented Nov 29, 2021

@SharakPL I am pretty sure 😄

I have overlaid a transparent Terminal window on top of Notepad and Chromium displaying the same font size.

image

image

It appears as though VS Code is the odd one out. Did you specify the font size in points?

@SharakPL
Copy link

Terminal doesn't specify the unit. I suspect it's in points and that's why it's much bigger. VSCode uses pixels.

@DHowett
Copy link
Member

DHowett commented Nov 29, 2021

Indeed, that's the central thesis of this issue :)

Terminal specifies font size in points, as do most text editors, terminals, web browsers and IDEs.

The traditional windows console used pixels (really "device independent pixels", which were scaled for the display's scaling factor.)

@SharakPL
Copy link

SharakPL commented Dec 15, 2021

Terminal specifies font size in points, as do most text editors, terminals, web browsers and IDEs.

Really? I would say points are good only for printers and designs made only to be printed, but for anything else that's supposed to be displayed on the screen (including editors, terminals and especially browsers) pixels should be used.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.
Projects
None yet
Development

No branches or pull requests

3 participants