Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Possible to get multiple selections visible with copyOnSelect enabled #5628

Closed
zadjii-msft opened this issue Apr 28, 2020 · 3 comments
Closed

Possible to get multiple selections visible with copyOnSelect enabled #5628

zadjii-msft opened this issue Apr 28, 2020 · 3 comments
Labels
Area-Rendering Text rendering, emoji, complex glyph & font-fallback issues Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Tag-Fix Doesn't match tag requirements Priority-3 A description (P3) Product-Terminal The new Windows Terminal.
Milestone
Terminal v1.0

Comments

@zadjii-msft
Copy link
Member

On the 0.11.1153.0 prerelease

Stick these in your globals:

    "copyOnSelect": true,
    "copyFormatting": false,

run dir to fill the buffer up, then ping -t google.com.

If you quickly select two different spots in the buffer, you can get both the old selection region and new selection region to be visible at the same time. I'm 88% sure this is purely graphical - it seems like the only actual selection is the second one, and as soon as more lines appear in the buffer, the old selection will disappear.

This might just be an ordering issue? Maybe we're not invalidating the old selection region when making a new one?

Weirdly, I couldn't get this to repro w/o running ping.
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Apr 28, 2020
@zadjii-msft zadjii-msft added Area-Rendering Text rendering, emoji, complex glyph & font-fallback issues Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-3 A description (P3) Product-Terminal The new Windows Terminal. labels Apr 28, 2020
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Apr 28, 2020
@DHowett-MSFT
Copy link
Contributor

This is definitely a regression from incremental R.

@zadjii-msft zadjii-msft added this to the Terminal v1.0 milestone Apr 29, 2020
@zadjii-msft
Copy link
Member Author

I'm just gonna shove this on 1.0, since it regressed with #5345 (et. al) but feel free to override me if this doesn't make the bar

@zadjii-msft
Copy link
Member Author

Hey so playing I'm with 0.11.1204.0, and I absolutely can't get this to repro anymore. This must have been fixed between 1153 and 1204

@DHowett-MSFT DHowett-MSFT removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Apr 30, 2020
@ghost ghost added the Needs-Tag-Fix Doesn't match tag requirements label Apr 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-Rendering Text rendering, emoji, complex glyph & font-fallback issues Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Tag-Fix Doesn't match tag requirements Priority-3 A description (P3) Product-Terminal The new Windows Terminal.
Projects
None yet
Milestone
Terminal v1.0
Development

No branches or pull requests
2 participants
@DHowett-MSFT @zadjii-msft