Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy into single line invalid #5283

Closed
hyahm opened this issue Apr 8, 2020 · 4 comments
Closed

Copy into single line invalid #5283

hyahm opened this issue Apr 8, 2020 · 4 comments
Labels
Issue-Question For questions or discussion Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting No-Recent-Activity This issue/PR is going stale and may be auto-closed without further activity.

Comments

@hyahm
Copy link

hyahm commented Apr 8, 2020

Ubuntu terminal

"keybindings": [
        { "command": { "action": "copy", "argument": true }, "keys": ["ctrl+shift+c"] }
    ]

It was good when I first opened the terminal, but when I log in to the server remotely, the copy will be in multiple lines, and it will be the same when I log out. I need to close the terminal and reopen it.

@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Apr 8, 2020
@zadjii-msft
Copy link
Member

@zadjii-msft zadjii-msft added the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Apr 8, 2020
@hyahm
Copy link
Author

hyahm commented Apr 9, 2020

@ghost ghost added Needs-Attention The core contributors need to come back around and look at this ASAP. and removed Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something labels Apr 9, 2020
@zadjii-msft
Copy link
Member

Okay yea, but that was more exemplary of how arguments are provided in general. None of the keybindings actually take a parameter named "argument" 😆

Command Command Description Action (*=required) Action Arguments Argument Descriptions
copy Copy the selected terminal content to your Windows Clipboard. singleLine boolean When true, the copied content will be copied as a single line. When false, newlines persist from the selected text.

So you probably want

{ "command": { "action": "copy", "singleLine ": true }, "keys": ["ctrl+shift+c"] }

Though, I believe we only changed the name of that parameter in the unreleased 0.11 builds. I think before that it was named "trimWhitespace". (it was changed here)

@zadjii-msft zadjii-msft added Issue-Question For questions or discussion Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something and removed Needs-Attention The core contributors need to come back around and look at this ASAP. labels Apr 9, 2020
@ghost ghost added the No-Recent-Activity This issue/PR is going stale and may be auto-closed without further activity. label Apr 13, 2020
@ghost
Copy link

ghost commented Apr 13, 2020

This issue has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 4 days. It will be closed if no further activity occurs within 3 days of this comment.

@hyahm hyahm closed this as completed Apr 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Question For questions or discussion Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting No-Recent-Activity This issue/PR is going stale and may be auto-closed without further activity.
Projects
None yet
Development

No branches or pull requests

2 participants