Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please add support closePaneRight/Left/Up/Down #4941

Closed
kgfly opened this issue Mar 16, 2020 · 5 comments
Closed

Please add support closePaneRight/Left/Up/Down #4941

kgfly opened this issue Mar 16, 2020 · 5 comments
Labels
Area-UserInterface Issues pertaining to the user interface of the Console or Terminal Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal. Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.

Comments

@kgfly
Copy link

kgfly commented Mar 16, 2020

Description of the new feature/enhancement

I want to look for a way to close eg right pane and bind it to a hot key.
Currently, to close eg right pane, I need move focus to right pane first. Then close it.

Proposed technical implementation details (optional)

Please add support closePaneRight/Left/Up/Down.
Then people can bind it to a hot key

Thanks.

@kgfly kgfly added the Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. label Mar 16, 2020
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Mar 16, 2020
@zadjii-msft
Copy link
Member

Okay I like the idea, but what happens when someone's got something like the following:

[ A | B | C ]

What happens when they closeRight from pane A? Or the even more complicated [ A | B | C | D ]? What happens when the nesting gets ridiculous like
image

@zadjii-msft zadjii-msft added Area-UserInterface Issues pertaining to the user interface of the Console or Terminal Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal. and removed Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. labels Mar 16, 2020
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Mar 16, 2020
@zadjii-msft zadjii-msft added this to the Terminal Backlog milestone Mar 16, 2020
@kgfly
Copy link
Author

kgfly commented Mar 16, 2020

In this case, [ A | B | C ]. What happens when they closeRight from pane A?
I suggest close B only.

I found, multi command binding, eg
{ "command": "moveFocusRight","command": "closePane", "keys": ["alt+l"] }
does not work.

That's why I propose.

Other software, such vim, supports above multi command binding easily.

Thanks.

@kgfly
Copy link
Author

kgfly commented Mar 16, 2020

If "multi command binding" is supported, that would be even better.

@zadjii-msft
Copy link
Member

Ah okay. What you really want is tracked over here, in #3992. Thanks for helping clarify!

/dup #3992

@zadjii-msft zadjii-msft removed this from the Terminal Backlog milestone Mar 16, 2020
@ghost
Copy link

ghost commented Mar 16, 2020

Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!

@ghost ghost closed this as completed Mar 16, 2020
@ghost ghost added Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing. and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Mar 16, 2020
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-UserInterface Issues pertaining to the user interface of the Console or Terminal Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal. Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.
Projects
None yet
Development

No branches or pull requests

2 participants