Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wt split-pane & wt new-tab commands open a new window #4792

Closed
ranyitz opened this issue Mar 3, 2020 · 2 comments
Closed

wt split-pane & wt new-tab commands open a new window #4792

ranyitz opened this issue Mar 3, 2020 · 2 comments
Labels
Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.

Comments

@ranyitz
Copy link

ranyitz commented Mar 3, 2020

Environment

Windows build number: Microsoft Windows [Version 10.0.18362.657]
Windows Terminal version (if applicable): Version: 0.9.433.0

Steps to reproduce

For split-pane:
Run wt split-pane

For new-tab:
Run wt new-tab

Expected behavior

For split-pane:
Split the pane of the current window.

For new-tab:
Open a new tab in the current window.

Actual behavior

For split-pane:
Open a new window an split the pane in this window into two.

For new-tab:
Open a new window with a new tab in it.

Context

While this behavior is mentioned in the docs

Opens a new tab with the given customizations. On its first invocation, also opens a new window. Subsequent new-tab commands will all open new tabs in the same window.

It doesn't feel right to me. If those commands would not open a new window, we'll be able to get the same experience through command composition. (Open a new window and then split this one into two)

Now the behavior of programmatically splitting a pane or opening a tab in the current window (which feels like the broad use-case) is something that with the current implementation is not possible to do.

@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Mar 3, 2020
@DHowett-MSFT
Copy link
Contributor

/dup #4472

@ghost
Copy link

ghost commented Mar 3, 2020

Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!

@ghost ghost closed this as completed Mar 3, 2020
@ghost ghost added Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing. and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Mar 3, 2020
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.
Projects
None yet
Development

No branches or pull requests

2 participants