Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings doesn't open reliably when there's no notepad.exe #4502

Closed
claudenobs opened this issue Feb 7, 2020 · 3 comments
Closed

Settings doesn't open reliably when there's no notepad.exe #4502

claudenobs opened this issue Feb 7, 2020 · 3 comments
Labels
Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.

Comments

@claudenobs
Copy link

Hi

I know there have been similar issues reported, like #1460 with solution #1841.

But i would like to raise this again, as it seems that :

  • when there is no notepad.exe (can be removed officially in next windows release)
  • and no editor associated with .json files

open settings seems totally broken, with absolutely no clue what's wrong.

I for one falsely assumed for months, that the settings functionality just hasn't been implemented yet (as it's still a preview)...

thanks

Environment

Microsoft Windows [Version 10.0.18363.592]

Steps to reproduce

  • remove notepad.exe
  • disassociate any editor from .json files
  • open settings in windows terminal

Expected behavior

settings are shown, or until #1564 is resolved, a simple popup with a path to the settings.json

Actual behavior

absolutely fantastically nothing

@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Feb 7, 2020
@zadjii-msft
Copy link
Member

For the record, when you don't have a .json editor set by default, the system is doing something. It's trying to figure out what your .json editor is. Once it eventually determines that there isn't one, it'll pop this dialog
image

The real problem here is that there's a pretty substantial delay between clicking the settings button and that dialog opening. I'm not sure how much we can really do about this. The easy workaround is just to make sure to set some application as the default editor for .json files, until #1564 lands.

This is also /dup #4486

@ghost
Copy link

ghost commented Feb 7, 2020

Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!

@ghost ghost closed this as completed Feb 7, 2020
@ghost ghost added Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing. and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Feb 7, 2020
@claudenobs
Copy link
Author

claudenobs commented Feb 9, 2020

For the record, when you don't have a .json editor set by default, the system is doing something. It's trying to figure out what your .json editor is. Once it eventually determines that there isn't one, it'll pop this dialog
image

how nice of you for not reading my issue and dismiss it by claiming false information.
i filed this issue exactly to point out that, such a menu you so nicely screenshot'ed does not appear.
and no it doesn't appear late, even after 5 minutes...

also very nice to close this a duplicate of #4486 and then closing that one too.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.
Projects
None yet
Development

No branches or pull requests

2 participants