Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opening a tab for a shell that is not installed anymore does not notify user that something went wrong #3192

Closed
PhMajerus opened this issue Oct 14, 2019 · 3 comments
Labels
Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.

Comments

@PhMajerus
Copy link

Environment

Windows build number: 18363.418
Windows Terminal version: 0.5.2762.0

If a profile is defined with an invalid commandline, or if the shell specified has been uninstalled by the user, trying to open a tab with that profile will not show any warning about the failure to launch the shell process.

If the profile is defined with "closeOnExit":false, the tab will wait forever for the shell to get connected instead of showing an error message. If the profile is defined with "closeOnExit":true, the tab will immediately close with no explanation.

Steps to reproduce

Create a profile with a non-existing shell such as the following:
{
// A non-existing shell
"guid": "{0225F6B6-EC1C-4746-8384-A83DB214D13A}",
"closeOnExit": false,
"name": "dummy",
"commandline": "dummyshell.exe",
"hidden": false
},

Expected behavior

If the commandline cannot be launched, an error should notify the user that the process couldn't be created, so they know they have to look at the command line more closely.

Actual behavior

Instead of some error message, Windows Terminal keeps the tab open and cursor waiting with no hint that something went wrong launching the shell, or simply silently closes the tab if "closeOnExit":true.

@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Oct 14, 2019
@DHowett-MSFT
Copy link
Contributor

Hey @PhMajerus, thanks for the report!
This is actually a dupe of #2563, for which we've got a couple plans.
Cheers!

@DHowett-MSFT
Copy link
Contributor

/dup #2563

@ghost
Copy link

ghost commented Oct 14, 2019

Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!

@ghost ghost closed this as completed Oct 14, 2019
@ghost ghost added Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing. and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Oct 14, 2019
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.
Projects
None yet
Development

No branches or pull requests

2 participants