Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terminal won't start / immediately crashes as of v0.5.2661.0 #2884

Closed
vsalvino opened this issue Sep 25, 2019 · 11 comments
Closed

Terminal won't start / immediately crashes as of v0.5.2661.0 #2884

vsalvino opened this issue Sep 25, 2019 · 11 comments
Labels
Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.

Comments

@vsalvino
Copy link

Environment

Windows build number: 10.0.18363.0
Windows Terminal version (if applicable): v0.5.2661.0

Any other software? PowerShell Core 6.2.2 is also installed.

Steps to reproduce

  1. Install windows terminal from either Microsoft Store, or via download from GitHub release.
  2. Try to launch the terminal.

Have tried un-installing/re-installing/rebooting multiple times to no avail.

Expected behavior

Terminal should launch, and at least show an error message.

Actual behavior

Terminal immediately crashes, you can see the ghost of a window frame before it disappears.

@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Sep 25, 2019
@DHowett-MSFT
Copy link
Contributor

Can you share the contents of your profiles.json? %LOCALAPPDATA%\Packages\Microsoft.WindowsTerminal_8wekyb3d8bbwe\LocalState\profiles.json

Thanks.

@DHowett-MSFT DHowett-MSFT added the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Sep 25, 2019
@vsalvino
Copy link
Author

Ah thanks for the path, was having trouble tracking down the install folder. The profile seems suspiciously small compared to past versions?

// To view the default settings, hold "alt" while clicking on the "Settings" button.
// For documentation on these settings, see: https://aka.ms/terminal-documentation

{
    "$schema": "https://aka.ms/terminal-profiles-schema",

    "defaultProfile": "{61c54bbd-c2c6-5271-96e7-009a87ff44bf}",

    "profiles":
    [
        {
            // Make changes here to the powershell.exe profile
            "guid": "{61c54bbd-c2c6-5271-96e7-009a87ff44bf}",
            "name": "Windows PowerShell",
            "commandline": "powershell.exe",
            "hidden": false
        },
        {
            // Make changes here to the cmd.exe profile
            "guid": "{0caa0dad-35be-5f56-a8ff-afceeeaa6101}",
            "name": "cmd",
            "commandline": "cmd.exe",
            "hidden": false
        },
        {
            "guid": "{574e775e-4f2a-5b96-ac1e-a2962a402336}",
            "hidden": false,
            "name": "PowerShell Core",
            "source": "Windows.Terminal.PowershellCore"
        },
        {
            "guid": "{b453ae62-4e3d-5e58-b989-0a998ec441b8}",
            "hidden": false,
            "name": "Azure Cloud Shell",
            "source": "Windows.Terminal.Azure"
        }
    ],

    // Add custom color schemes to this array
    "schemes": [],

    // Add any keybinding overrides to this array.
    // To unbind a default keybinding, set the command to "unbound"
    "keybindings": []
}

@ghost ghost added Needs-Attention The core contributors need to come back around and look at this ASAP. and removed Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something labels Sep 25, 2019
@DHowett-MSFT
Copy link
Contributor

Indeed! That's part of the recent settings reform.

Since it doesn't look like a bad default profile, would you mind sharing a feedback hub link?

@DHowett-MSFT
Copy link
Contributor

/feedback

@ghost
Copy link

ghost commented Sep 25, 2019

Hi there!

Can you please send us feedback with the Feedback Hub with this issue and paste the link here so we can more easily find your crash information on the back end?

Thanks!

image image

@ghost ghost added the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Sep 25, 2019
@vsalvino
Copy link
Author

Feedback hub: https://aka.ms/AA63w7j

@ghost ghost removed the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Sep 25, 2019
@vsalvino
Copy link
Author

vsalvino commented Sep 25, 2019

After tinkering with the profile.json, It only exhibits this problem when trying to open a Windows PowerShell terminal (which was the default). Changing the default to PowerShell Core or CMD works! Same problem persists when trying to open a Windows PowerShell tab: the new tab immediately crashes/closes.

Investigating further, powershell.exe is not on the PATH. If I change this to the full path to the executable, it works (C:\\Windows\\System32\\WindowsPowerShell\\v1.0\\powershell.exe).

Perhaps a couple ideas here, start by providing the full path in the default profile.json, and also show an error if there is a problem executing commandline.

@DHowett-MSFT
Copy link
Contributor

If powershell's not on your path, that's a sign of a serious system misconfiguration. Has something changed the systemwide PATH variable? The system-provided powershell should definitely be there.

Otherwise, this is /dup #2563.

@ghost
Copy link

ghost commented Sep 25, 2019

Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!

@ghost ghost closed this as completed Sep 25, 2019
@ghost ghost added Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing. and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements Needs-Attention The core contributors need to come back around and look at this ASAP. labels Sep 25, 2019
@vsalvino
Copy link
Author

Thanks for the help. Glad there is already an issue for this problem. Yes, many things have changed the PATH over the years (countless developer tools such as git, python, node/npm, ruby, dotnet, docker, and all of the other cruft that comes along with such toolchains). I imagine some botched install or crappy tool must have hosed the PATH at one time.

@GaaTY
Copy link

GaaTY commented Oct 2, 2019

I can confirm the PATH thing.

The app was also closing on startup, checked my PATH. No reference to powershell. Added the powershell path to PATH, Terminal opens on my default (which I set to Powershell).

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.
Projects
None yet
Development

No branches or pull requests

3 participants