Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closing a PowerShell pane over a CMD pane that covers the view with text locks UI thread #2433

Closed
richardszalay opened this issue Aug 14, 2019 · 3 comments
Closed

Closing a PowerShell pane over a CMD pane that covers the view with text locks UI thread #2433

richardszalay opened this issue Aug 14, 2019 · 3 comments
Labels
Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting

Comments

@richardszalay
Copy link
Contributor

richardszalay commented Aug 14, 2019 •
edited
Loading

Environment

Windows build number: Microsoft Windows [Version 10.0.18362.175]
Windows Terminal version (if applicable):0.3.2171.0

Steps to reproduce

Forgive the title - I couldn't think of a good way of articulating it

  1. Set the default profile to PowerShell
  2. Create a cmd tab
  3. Press enter until the text covers most of the screen
  4. Split the view horizontally
  5. Close the bottom pane

Does not repro if:

  • The primary tab's text does not fill the screen
  • The secondary/bottom pane is not PowerShell
  • The primary/top pane is Ubuntu/WSL, and exhibits a different bug if the primary/top pane is PowerShell
  • The bottom/PowerShell pane loses focus (either to an external window or to the top pane)

Expected behavior

The pane closes

Actual behavior

The UI thread hangs. Screenshots:

pane-crash-1

pane-crash-2

pane-crash-3
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Aug 14, 2019
@richardszalay richardszalay changed the title Closing a pane that covers text of a cmd locks UI thread Closing a PowerShell pane over a CMD pane that covers the view with text locks UI thread Aug 14, 2019
@richardszalay
Copy link
Contributor Author

richardszalay commented Aug 15, 2019 •
edited
Loading

Some quick debugging on this shows that it's blocked waiting for ConhostConnection._hJob.reset() in ConhostConnection::Close. My lack of c++ knowledge is prohibiting me from actually figuring out how to fix this to PR (sorry!)

@richardszalay richardszalay mentioned this issue Aug 15, 2019
Closed
@DHowett-MSFT
Copy link
Contributor

This is a duplicate of #2248, then. 😄

@richardszalay
Copy link
Contributor Author

Touché

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@richardszalay @DHowett-MSFT