Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Interactive performance is horrible after displaying a full screen image with viu #2274

Closed
jeichorn opened this issue Aug 6, 2019 · 1 comment
Closed

Interactive performance is horrible after displaying a full screen image with viu #2274

jeichorn opened this issue Aug 6, 2019 · 1 comment
Labels
Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.

Comments

@jeichorn
Copy link

jeichorn commented Aug 6, 2019

Environment

Windows build number: Microsoft Windows [Version 10.0.18362.239]
Windows Terminal version 0.3.2142.0
Testing using wsl 1.0,  Ubuntu 18.04.2 LTS
viu 0.2.1 https://crates.io/crates/viu

Steps to reproduce

Install viu, and display an image big enough to be full screen
cargo install viu
viu /mnt/c/.../image.jpg

type

Expected behavior

No performance drop

Actual behavior

Typing performance will be horrible until the image has been scrolled off the screen. Bad enough that typing will have 1 second of lag.
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Aug 6, 2019
@DHowett-MSFT
Copy link
Contributor

Probably two issues here. One is #778, one is #1064. Also, we're probably reserializing the entire buffer over conpty again and again. Sometimes it happens.

@DHowett-MSFT DHowett-MSFT added the Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing. label Aug 16, 2019
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Aug 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jeichorn @DHowett-MSFT