Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Find the actual issue keeping conhosts from exiting when tabs are closed #2185

Closed
miniksa opened this issue Jul 31, 2019 · 2 comments · Fixed by #2198
Closed

Find the actual issue keeping conhosts from exiting when tabs are closed #2185

miniksa opened this issue Jul 31, 2019 · 2 comments · Fixed by #2198
Assignees
@miniksa
Labels
Area-Quality Stability, Performance, Etc. Area-Server Down in the muck of API call servicing, interprocess communication, eventing, etc. Area-TerminalConnection Issues pertaining to the terminal<->backend connection interface Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal. Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.
Milestone
Terminal-1911

Comments

@miniksa
Copy link
Member

miniksa commented Jul 31, 2019

We have a job object for the conhost in PTY mode that is supporting the connection on each tab. But this was because the conhosts weren't exiting.

However, conhosts should just exit when they have nothing to do.

This represents taking the job object off and figuring out what the actual underlying issue is that is keeping the conhost from realizing it can just exit.
@miniksa miniksa added Area-Server Down in the muck of API call servicing, interprocess communication, eventing, etc. Area-TerminalConnection Issues pertaining to the terminal<->backend connection interface Product-Terminal The new Windows Terminal. Issue-Task It's a feature request, but it doesn't really need a major design. labels Jul 31, 2019
@miniksa miniksa self-assigned this Jul 31, 2019
@ghost ghost added the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Jul 31, 2019
@miniksa miniksa added this to the Terminal 1908.1 milestone Jul 31, 2019
@miniksa miniksa removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Jul 31, 2019
@miniksa miniksa mentioned this issue Aug 1, 2019
Merged
5 tasks
@ghost ghost added the In-PR This issue has a related PR label Aug 1, 2019
@ghost ghost added Needs-Tag-Fix Doesn't match tag requirements Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed In-PR This issue has a related PR labels Aug 2, 2019
@miniksa miniksa reopened this Aug 2, 2019
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Aug 2, 2019
@DHowett-MSFT DHowett-MSFT mentioned this issue Aug 5, 2019
Closed
@zadjii-msft zadjii-msft mentioned this issue Aug 19, 2019
Closed
@DHowett-MSFT DHowett-MSFT removed the Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. label Aug 26, 2019
@zadjii-msft zadjii-msft mentioned this issue Aug 26, 2019
Closed
@ghost
Copy link

ghost commented Aug 27, 2019

🎉This issue was addressed in #2198, which has now been successfully released as Windows Terminal Preview v0.4.2382.0.:tada:

Handy links:

@bitcrazed bitcrazed added Severity-Crash Crashes are real bad news. Area-Quality Stability, Performance, Etc. labels Sep 12, 2019
@zadjii-msft zadjii-msft removed the Severity-Crash Crashes are real bad news. label Sep 13, 2019
@DHowett-MSFT DHowett-MSFT mentioned this issue Sep 23, 2019
Closed
@zadjii-msft zadjii-msft removed this from the Terminal-1909 milestone Sep 24, 2019
@zadjii-msft zadjii-msft added this to the Terminal-1910 milestone Sep 24, 2019
@miniksa miniksa added Mass-Chaos Temporary use to trigger the bot. and removed Mass-Chaos Temporary use to trigger the bot. labels Oct 14, 2019
@zadjii-msft
Copy link
Member

We think this was actually probably resolved by #2525. It's not happening anymore, so we're going to resolve it for now?

@ghost ghost added the Needs-Tag-Fix Doesn't match tag requirements label Oct 25, 2019
@zadjii-msft zadjii-msft added Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing. and removed Needs-Tag-Fix Doesn't match tag requirements labels Oct 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@miniksa miniksa

Labels
Area-Quality Stability, Performance, Etc. Area-Server Down in the muck of API call servicing, interprocess communication, eventing, etc. Area-TerminalConnection Issues pertaining to the terminal<->backend connection interface Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal. Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.
Projects
None yet
Milestone
Terminal-1911
Development

Successfully merging a pull request may close this issue.

Remove job object and startup suspended behavior microsoft/terminal
5 participants
@bitcrazed @DHowett-MSFT @miniksa @zadjii-msft @cinnamon-msft