Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Waveterm-like features #16502

Open
3 tasks
Marin-Kitagawa opened this issue Dec 28, 2023 · 2 comments
Open
3 tasks

Waveterm-like features #16502

Marin-Kitagawa opened this issue Dec 28, 2023 · 2 comments
Labels
Area-UserInterface Issues pertaining to the user interface of the Console or Terminal Issue-Scenario Product-Terminal The new Windows Terminal.
Milestone

Comments

@Marin-Kitagawa
Copy link

Marin-Kitagawa commented Dec 28, 2023

Description of the new feature/enhancement

I have come across Waveterm which is only available for Linux and MacOS. It has really nice features such as

  1. Workspaces
  2. Inline code viewing and editing
  3. Viewing Markdown, JSON, CSV and images all in the terminal
  4. Viewing universal history (commands run universally in all machines)

Could you please implement these features to the Windows Terminal as well?

Also I have previously created an issue #13122 which is now converted to a discussion #13146 . These refer to Warp-terminal like features. Would be nice to have the above features included as well.

Tasks

Preview Give feedback
@Marin-Kitagawa Marin-Kitagawa added the Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. label Dec 28, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Dec 28, 2023
@zadjii-msft
Copy link
Member

zadjii-msft commented Jan 3, 2024

I think the "workspaces" sounds a lot like "named sessions". This I don't hate. Like, if you could close a workspace and re-open it ala Edge Workspaces. That's a good idea. I suppose there's no reason today (other than we need to write a bit of code) that a named window couldn't be persisted separately outside the persistedWindowLayouts, and when that's opened cold, we could see if there's something in the state.json for that window first.

The inline stuff is intriguing, but I'm guessing that the way waveterm implements it is very tightly coupled to their own "shell" implementation. If we were gonna do this, we'd want to do it in a way that'd be universally consumable regardless of terminal emulator. I was just talking to @DHowett about this before the break:

then i had this fever dream where you could like emit

OSC 9001 markdown <rows> <columns>
<literal markdown>
OSC 9001 /markdown

or csv or fuck, png (like, literally raw png bytes) (like literally, cat manningface.png)

and then we'd reserve that much space in the buffer, and draw the file however we were prepared to render it. And we'd just do this "on top of" the buffer so if you like, blat manning into the terminal then move the cursor over his face to repaint it, then too bad?

Of course, inline editing would be really hard, cause you'd have to somehow spawn a process on the (possibly remote) machine to persistently listen for "saves" from the Terminal, and then send those to the file to write it - I'd probably rather not be in the business of that.

also xlink #13445 for my own reference

@zadjii-msft zadjii-msft added Issue-Scenario and removed Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. labels Jan 3, 2024
@carlos-zamora carlos-zamora added Area-UserInterface Issues pertaining to the user interface of the Console or Terminal Product-Terminal The new Windows Terminal. and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Jan 10, 2024
@carlos-zamora carlos-zamora added this to the Backlog milestone Jan 10, 2024
@SeanFeldman
Copy link

Another fascinating terminal approach is warp.dev. Worth looking at the features it's offering.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-UserInterface Issues pertaining to the user interface of the Console or Terminal Issue-Scenario Product-Terminal The new Windows Terminal.
Projects
None yet
Development

No branches or pull requests

4 participants