Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The text is flickering when switching options #15716

Closed
Noah-Ywh opened this issue Jul 15, 2023 · 6 comments
Closed

The text is flickering when switching options #15716

Noah-Ywh opened this issue Jul 15, 2023 · 6 comments
Labels
Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Attention The core contributors need to come back around and look at this ASAP. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting

Comments

@Noah-Ywh
Copy link

Windows Terminal version

1.17.11461.0

Windows build number

22621.1848

Other Software

npm:git-cz

Steps to reproduce

To submit code using git-cz

Expected Behavior

No response

Actual Behavior

-.Made.with.Clipchamp.mp4
@Noah-Ywh Noah-Ywh added Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Jul 15, 2023
@Noah-Ywh Noah-Ywh reopened this Jul 15, 2023
@zadjii-msft
Copy link
Member

Does this repro in a conhost.exe window/?

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Jul 17, 2023
@Noah-Ywh
Copy link
Author

Does this repro in a conhost.exe window/?

This is a repro in conhost.exe.

conhost.mp4

Also, I only encountered the issue on a laptop computer.

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Attention The core contributors need to come back around and look at this ASAP. and removed Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something labels Jul 17, 2023
@zadjii-msft
Copy link
Member

Since this repros in conhost, I'd guess this is an upstream issue with git-cz itself. The way it's redrawing the whole TUI each frame seems... inoptimal. Though that's probably more an issue with whatever lib they're using to draw than anything else.

That being said - what they're outputting here also doesn't look terribly expensive to output. Maybe there's some specific sequence of clear & print they're using that's specifically causing a frame to flush with the screen blanked.

Though, very peculiar that it repros even in conhost directly, on 22621. That makes me think it's not the #14677 bug.

@zadjii-msft
Copy link
Member

Interestingly enough, I can repro this slightly on 1.18, and not at all on conhost (from 10.0.25903.1000) nor gnome-terminal. I reckon this is probably somehow throughput bound. It shouldn't be for a menu as trivial as this, but might be.

@Noah-Ywh
Copy link
Author

I have installed git-cz on a remote Ubuntu system. When I access and use git-cz via SSH on my desktop computer, it works fine. However, when I access and use git-cz via my laptop computer, I encounter this issue. I have tested this on both two desktop computers and two laptops separately.

@Noah-Ywh
Copy link
Author

@zadjii-msft
Perhaps it has something to do with the rendering mechanism of the laptop computer! Nevertheless, thank you for patiently reading through my poor English and responding. Thank you.

@Noah-Ywh Noah-Ywh closed this as not planned Won't fix, can't repro, duplicate, stale Jul 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Attention The core contributors need to come back around and look at this ASAP. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting
Projects
None yet
Development

No branches or pull requests

2 participants