-
Notifications
You must be signed in to change notification settings - Fork 8.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SGR Blinking doesn't work in conjunction with Faint #15676
Comments
For reference, the environment variables are set via my own set-colors.bat: Other than the "%@char[27]" TCC-specific syntax I use to set the escape character, if you fix that one part, this should work for any command line, and is quite convenient for echoing messages using the advanced ANSI styling that Windows Terminal finally brings to the table so eloquently. But yea, I'm in the ditches testing, and found this one odd behavior :)
|
Great catch! @j4james I remember we (you!) made the conscious decision to use faint colors for blink rather than e.g. libvte's "text is invisible while blink-off". I've got some ideas on how to handle this one:
Is there precedent, or preference, on your side? 😄 |
Oh i think it should blink to fainter color If it blinked to a brighter color, there's the danger of blink+faint looking the same as normal+faint, but simply inverted. At that point, it's literally the same as blink+reverse. Poo. It should be a unique and recognizable entity: blinking just like a normal blink, but faint just like faint. And if it just became invisible, it would be the same as conceal and basically have none of the nature of blink and very little of the nature of faint. so #1: make it even fainter! |
Well, it would still be visible half the time! Point taken, though. 😄
90% of this was James' work, and he's the G.O.A.T. |
Ohhh, I mis-understood. Doesn't change my answer to which option I think is better, but gives me more respect for that option 😅
Thank you James!!!!!! 🎉🎉🎉 |
Thanks for raising this @ClaireCJS. Although it's obvious in retrospect I don't think I realised at the time that this combination wouldn't work. I'm happy with the idea of making the blinking faint even fainter. 1 That said, I'm in the process of overhauling a lot of the rendition code at the moment, because I'm trying to implement the Footnotes
|
I really did stumble upon it by accident!
Wow. That sounds really fun, though.
Anyone else getting Doctor Who/Quantum Leap vibes? It's like you're getting to fix history's mistakes! :) 🎉🎉🎉 |
@ClaireCJS I tried using |
I typically just print the actual ANSI codes to STDOUT without using any packages. Try both fast & slow blink codes.
|
And if all else fails, pipe it through cygwin's cat.exe that almost always fixes ANSI rendering problems! |
Even " |
@nerdatwork If you're using Windows PowerShell you need something like this:
And on newer versions of PowerShell you can use this:
If you still can't see the text blinking, it may be because you have Windows animations disabled. You'll find that option somewhere in your Windows settings, typically in the Ease of Access or Accessibility section. Just search for animations and you should find it. Also make sure you haven't set the cursor blink rate to None, because that will also disable text blinking. The other reason you may not be seeing blinking is if you're accessing a remote computer with Remote Desktop. If that's the case, open the Options page before you start the connection, and look under the Experience tab. You should find a Menu and window animation option there. And note that you may need to restart Windows Terminal after changing any of these settings. |
@j4james Thank you. It was the PS: Anyone else facing this issue, don't forget to restart Windows Terminal for new changes to take effect. |
Windows Terminal version
1.17.11461.0
Windows build number
10.0.19045.3086
Other Software
No response
Steps to reproduce
use ansi codes to render blinking faint text
Expected Behavior
text blinks, but is fainter than non-faint blinking text
Actual Behavior
text doesn't blink at all
see video
windows.terminal.blinking.not.for.faint.mp4
The text was updated successfully, but these errors were encountered: