Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stick profile appearance settings into Theme objects for easier sharing of settings #13991

Open
Tracked by #3327
zadjii-msft opened this issue Sep 14, 2022 · 1 comment
Open
Tracked by #3327

Stick profile appearance settings into Theme objects for easier sharing of settings #13991

zadjii-msft opened this issue Sep 14, 2022 · 1 comment
Labels
Area-Theming Anything related to the theming of elements of the window Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Product-Terminal The new Windows Terminal.
Milestone
Backlog

Comments

@zadjii-msft
Copy link
Member

A fever dream I had:
 
theme.profile { an appearance }, and we use that as the "hardcoded default" (or, I suppose the first layer).

That would let folks put the WHOLE appearance of the terminal into a theme, for sharing. background images, background colors, color schemes, fonts, you name it. Now it's just one blob you put into the settings.

Settings from dynamic profiles, profiles.defaults, and profile settings would all still take precedence.
@zadjii-msft zadjii-msft added Product-Terminal The new Windows Terminal. Issue-Task It's a feature request, but it doesn't really need a major design. Needs-Discussion Something that requires a team discussion before we can proceed Area-Theming Anything related to the theming of elements of the window labels Sep 14, 2022
@ghost ghost added the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Sep 14, 2022
@zadjii-msft
Copy link
Member Author

zadjii-msft commented Sep 14, 2022 •
edited
Loading

theme-profile-proto

branch: https://github.com/microsoft/terminal/compare/dev/migrie/b/theme.profile

[12:44 PM] Dustin Howett
i'm also worried about the general "where do i put my settings" problem

[12:45 PM] Mike Griese
This is more of a hypothetical: I want to bundle the whole screenshot of my terminal into one object for others. wat do.

[12:46 PM] Mike Griese
otherwise, it's like... import theme > "we found some profile settings in this theme - which profiles would you like to apply these to?"

[12:46 PM] Mike Griese
idk

@zadjii-msft zadjii-msft mentioned this issue Sep 14, 2022
Open
27 tasks
@zadjii-msft zadjii-msft added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Mass-Chaos Temporary use to trigger the bot. Needs-Discussion Something that requires a team discussion before we can proceed and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Mass-Chaos Temporary use to trigger the bot. Needs-Discussion Something that requires a team discussion before we can proceed labels Sep 14, 2022
@zadjii-msft zadjii-msft added Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. and removed Issue-Task It's a feature request, but it doesn't really need a major design. Needs-Discussion Something that requires a team discussion before we can proceed labels Oct 24, 2022
@zadjii-msft zadjii-msft added this to the Backlog milestone Oct 24, 2022
@zadjii-msft zadjii-msft changed the title Stick profile appearance settings into Theme objects Stick profile appearance settings into Theme objects for easier sharing of settings Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-Theming Anything related to the theming of elements of the window Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Product-Terminal The new Windows Terminal.
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
1 participant
@zadjii-msft