Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows 10: Terminal does not update when the OS theme changes #12682

Open
sergiubacioiu opened this issue Mar 12, 2022 · 3 comments
Open

Windows 10: Terminal does not update when the OS theme changes #12682

sergiubacioiu opened this issue Mar 12, 2022 · 3 comments
Labels
Area-UserInterface Issues pertaining to the user interface of the Console or Terminal Help Wanted We encourage anyone to jump in on these. Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-3 A description (P3) Product-Terminal The new Windows Terminal.
Milestone
Icebox ❄

Comments

@sergiubacioiu
Copy link

Windows Terminal version

1.13.10395.0

Windows build number

10.0.19044.0

Other Software

No response

Steps to reproduce

Open Terminal -> Settings -> Appearance -> Theme and make sure that "Use Windows theme" is active.

After changing the OS color theme the Terminal interface is not updated only after an app restart.

Expected Behavior

Update theme based on OS preferred color scheme without restarting the app.

Actual Behavior

The theme is not updated without a restart.
@sergiubacioiu sergiubacioiu added the Issue-Bug It either shouldn't be doing this or needs an investigation. label Mar 12, 2022
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Mar 12, 2022
@j4james
Copy link
Collaborator

j4james commented Mar 13, 2022 •
edited
Loading

This was previously raised in #1230, but that issue is currently closed as "resolution-external", because the problem is fixed in Windows 11. So for now, the answer is that you'll need Windows 11 if you want this to work correctly.

That said, I think it might still be possible to get it working in Windows 10. I had a partial solution a while back that looked promising, but I got sidetracked with other stuff and haven't had a chance to get back to it. If/when I do finish that off, the PR should be tracked in #1230.

@rashil2000
Copy link
Contributor

rashil2000 commented Mar 17, 2022 •
edited
Loading

I'm using Windows 11 Build 22572 and still facing this issue. Terminal version 1.13.10395.0

The titlebar does not fully react to system theme change. The whole window needs to be restarted. Even manually changing the value of "theme" does not make it react immediately.

@zadjii-msft
Copy link
Member

@rashil2000 you might be seeing something like #12356.

I suppose I'll leave this open to handle the Windows 10 fix for #1230, to make it clearer that #1230 isn't fixed on 10.

@zadjii-msft zadjii-msft added Help Wanted We encourage anyone to jump in on these. Area-UserInterface Issues pertaining to the user interface of the Console or Terminal Product-Terminal The new Windows Terminal. Priority-3 A description (P3) labels Mar 17, 2022
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Mar 17, 2022
@zadjii-msft zadjii-msft added this to the Icebox ❄ milestone Mar 17, 2022
@zadjii-msft zadjii-msft removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Mar 17, 2022
@zadjii-msft zadjii-msft changed the title Update theme based on OS preferred color scheme Windows 10: Terminal does not update when the OS theme changes Mar 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-UserInterface Issues pertaining to the user interface of the Console or Terminal Help Wanted We encourage anyone to jump in on these. Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-3 A description (P3) Product-Terminal The new Windows Terminal.
Projects
None yet
Milestone
Icebox ❄
Development

No branches or pull requests
4 participants
@sergiubacioiu @j4james @zadjii-msft @rashil2000