Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend GetConsoleMode or add an new API set, to allow guest programs to distinguish CONHOST and Windows Terminal #1153

Closed
reli-msft opened this issue Jun 5, 2019 · 1 comment
Labels
Area-Interop Communication between processes Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Product-Conpty For console issues specifically related to conpty Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.

Comments

@reli-msft
Copy link

An equivalance to $TERM but more powerful:

HRESULT GetTerminalSupport(HANDLE hConsole, LPCWSTR featureName, INT *pSupport);

featureName may include "FontFallback", "Emoji", "Ligatures", etc.

@reli-msft reli-msft added the Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. label Jun 5, 2019
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Jun 5, 2019
@DHowett-MSFT
Copy link
Contributor

Hey @reli-msft, thanks for suggesting this.

Since we're in Windows, we're very, very hesitant to introduce additional APIs. They need board review, and we can only release new APIs with new versions of Windows. The sheer complexity of doing that, especially given that the long tail of applications will never use this particular one, gives me a lot of pause.

This one in particular is complicated by the fact that we'd need to extend the pseudoconsole protocol, which today is simply raw VT52/100/220 over two pipes (we'd like to keep it that way!), to support some modicum of feature detection requests... and then beg all future terminals that consume the pseudoconsole API to also play along by answering feature requests. It'd be a step backwards on our equitable participation in standards to ask that just yet.

I'd like to come to a good solution here, but I'm not sure a new API is it. We should probably converge the discussion over in #1040, which is practically the same thing. 😄

@DHowett-MSFT DHowett-MSFT added Area-Interop Communication between processes Product-Conpty For console issues specifically related to conpty Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing. and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Jun 6, 2019
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Jun 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Interop Communication between processes Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Product-Conpty For console issues specifically related to conpty Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.
Projects
None yet
Development

No branches or pull requests

2 participants