Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terminal Unexpectedly Closing #11074

Closed
samhenrigold opened this issue Aug 28, 2021 · 14 comments
Closed

Terminal Unexpectedly Closing #11074

samhenrigold opened this issue Aug 28, 2021 · 14 comments
Labels
Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Product-Terminal The new Windows Terminal. Resolution-No-Repro We couldn't get this to happen, or it stopped happening entirely. Severity-Crash Crashes are real bad news.

Comments

@samhenrigold
Copy link

Windows Terminal version (or Windows build number)

10.0.19043.0

Other Software

  • Ubuntu 20.04.3 inside WSL

Steps to reproduce

WT (stable or preview) will close in under a minute after opening it. It doesn't matter if it's sitting idle, if I've opened a tab, or if I've run a command before, it crashes within seconds.

This issue started today when I updated Windows from stable to the release preview channel, the Terminal issue began. I restored back to a system image I took last night and I'm now having the same issue on this image where I didn't have it before. Using cmd.exe, PowerShell, the standalone Ubuntu program, or the terminal inside VS Code works fine, it's specifically Windows Terminal.

No events are logged in the event viewer, I'm fairly new to Windows so I don't know how to troubleshoot further. Feedback Hub link and video showing the issue:

2021-08-28.10-30-39.mp4

Expected Behavior

Terminal to not close (crash?) without me closing it.

Actual Behavior

Opening the terminal (stable or preview) and doing anything, the terminal will close within a minute of opening it.

@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Aug 28, 2021
@zadjii-msft
Copy link
Member

Huh. Exception's being thrown somewhere in Terminal.Settings.Model. An E_BOUNDS exception... I wonder what would possibly throw that like, 20s after launch? Maybe querying the WSL distros? But that's already been completed, as you can see them in the list of profiles in the dropdown.

I am having a hard time looking through the full dump myself though, I can't seem to find it on the backend. Maybe I just haven't had enough coffee yet? @DHowett help me out with this one?

@zadjii-msft zadjii-msft added Product-Terminal The new Windows Terminal. Severity-Crash Crashes are real bad news. labels Aug 30, 2021
@samhenrigold
Copy link
Author

@zadjii-msft @DHowett Howdy! Sorry to bug today, just wondering to see if this got any more thought. Hope you're having a good labor day, thanks for your help!

@ghost
Copy link

ghost commented Apr 20, 2022

@zadjii-msft I'll jump in on this issue as it matches what I'm seeing.

I've had this problem for over 2 years. Every 4-6 months I will try a fresh install and I've not seen a difference in behavior.

Fresh install this morning from MS store. v 1.12.10982.0
Launch, wait 5-10 seconds, then window just vaporizes.

If there are diagnostics/dumps I can take for someone to investigate, I'm happy to provide (will need instructions)

Just now, I launched 3 separate WT instances:

  1. Opens to PowerShell. Quickly opened 2nd tab to CMD, then closed PS tab.
  2. Launch another instance of WT. Leave that one on PS.
  3. Launch a 3rd WT window. Open an ubuntu tab.

On window #3, ubuntu started up. I ran sudo apt update. At some point during that, window #1 crashed and closed.
About 10 seconds later, window #2 crashed and closed.
In Window #3, my apt update finished. I then continued with 'sudo apt upgrade' and about 5 seconds into that, window #3 crashed.

system: W10 Home, 21H1 19043.1645
WSL2 installed - ubuntu 20.04

@zadjii-msft
Copy link
Member

@ghammond-banyan Can you try a recording this with the Feedback Hub, and sharing the link here? I'm betting the original FH link in this issue got wiped from the cache by now, but let's get your crash dump anyways just to make sure.

I'd also recommend setting "closeOnExit": "never", just in case it's the client app crashing and the terminal just auto closing itself (which it does weirdly sound like is what's happening)

@ghost
Copy link

ghost commented Apr 27, 2022

@zadjii-msft here you go https://aka.ms/AAgr87s

I added closeOnExit to settings, but that didn't affect anything.

Thanks for looking at this.

This was on my work machine, which is W10 Pro 21H2 19044.1645

@zadjii-msft
Copy link
Member

Frick. If there was a dump for this one in the backend, it must have been cleared out by now, but maybe there wasn't.

We have however been blind-firing fixes for a bunch of crashes, especially over the last few months. Perhaps we just fixed this one along the way? Could you try out https://github.com/microsoft/terminal/releases/tag/v1.15.2282.0 and see if this has been fixed?

If it isn't, then can you try following the steps in this post to set up automatic crash dumps? (For more info, see this link) If that works, then you should be able to automatically get a .dmp of the terminal when it crashes. Then, can you zip that dump up and send it to us, so we can investigate/?

That's really my last idea at this point 😕

@ghost ghost added the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Aug 18, 2022
@samhenrigold
Copy link
Author

I’m aware this is the least helpful conclusion but since this post, my business switched to a Mac and sent my Windows machine back so I wouldn’t be able to test the fixes. For what it’s worth, I haven’t had the same issue in my W11 ARM VM 😅

@ghost ghost added Needs-Attention The core contributors need to come back around and look at this ASAP. and removed Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something labels Aug 18, 2022
@greg-hammond
Copy link

Same here - I'm Mac-only for the time being. When I get my Windows machine back up I'll check out the above @zadjii-msft

Thanks.

@zadjii-msft
Copy link
Member

WELP that's definitely not what you love to hear, but at least it's something. @greg-hammond if you do see this again, follow up here and we can reopen.


<off topic>

Entirely genuinely - is there a particular reason you switched to MacOS? If you've got specific reasons, I always love forwarding feedback to the appropriate internal parties 😄

@zadjii-msft zadjii-msft closed this as not planned Won't fix, can't repro, duplicate, stale Aug 18, 2022
@zadjii-msft zadjii-msft added Resolution-No-Repro We couldn't get this to happen, or it stopped happening entirely. and removed Needs-Attention The core contributors need to come back around and look at this ASAP. labels Aug 18, 2022
@greg-hammond
Copy link

@zadjii-msft I'm working as a contractor for a large employer - their engineering group is mac/linux exclusively. If there are specific reasons why their ecosystem doesn't support Windows, I don't know what they are, but ostensibly there are reasons.

@zadjii-msft
Copy link
Member

That makes perfect sense! Thanks for the follow up ☺️

@samhenrigold
Copy link
Author

I’ve been trying to synthesize my thoughts but I think it comes down to the apps (system and the ones generally available in the wider ecosystem) and features.

There are some apps built into Mac that I’ve really come to appreciate as a designer. Font Book just got a facelift as a place to view my installed fonts, its OpenType features and metadata, the repertoire of characters, and even print out waterfall/catalog specimens. I haven’t been able to find a good, modern-looking stand-in for that on Windows.

And a general-purpose image and PDF viewer like Preview.app is something I found myself missing constantly on Windows. Re-ordering pages of a PDF, extracting pages, rescaling and color corrections, etc. all required me to look for other tools or install an overpowered app like Photoshop.

For the features, it’s mostly stuff that I could find replacements for on Windows but found silly that I even had to:

  • Screen recorders without having to involve the Xbox Game Bar,
  • Better type rendering,
  • Writing AutoHotKey scripts to reducing the number of shortcuts that use uncomfortable-to-reach keys (to select all text from the beginning of the current line to your cursor point, the shortcut on Mac is Command+Shift+Left. On Windows, it’s the Home key + Shift. That's a wild ergonomic stretch on a laptop),
  • Utilities that force a brutalist dark mode for odds and ends that haven’t been updated to support dark mode

Not really a feature but a paper cut I kept running into as a non-native Windows user:

  • Drag and drop locations. Let’s say I'm trying to upload a file sitting in ~/Documents/Clients/Acme/Presentation.pdf and I've got that file location open in an Explorer window. Edge opens the file picker and it's pointed at the desktop. I think dragging that file from the explorer window onto the file picker should point the file picker to that location rather than copying the dragged file to the desktop.

This was supposed to be a blog post that I never finished writing, apologies for the chaotic formatting

@zadjii-msft
Copy link
Member

Thanks for all this - this is great feedback that I hopefully can bounce around to some folks 🙂

@greg-hammond
Copy link

WELP that's definitely not what you love to hear, but at least it's something. @greg-hammond if you do see this again, follow up here and we can reopen.

@zadjii-msft

Following up again - just tried a new install and still hitting the same thing.
Dusted off and updated my old machine. Win10 Pro 22H2 19045.2364.
Did a fresh WT install from the MS store (1.15.3465.0).
Opened it, same result. Window closes usually within 5-10 seconds, whether or not I interact with it.
What should I try? Care to triage this together?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Product-Terminal The new Windows Terminal. Resolution-No-Repro We couldn't get this to happen, or it stopped happening entirely. Severity-Crash Crashes are real bad news.
Projects
None yet
Development

No branches or pull requests

3 participants