Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terminal App Version 1.8.1521.0 crashes on openssh client connection exit (WSL2 Ubuntu buster/sid Linux) #10657

Closed
ministry-of-code opened this issue Jul 14, 2021 · 10 comments
Labels
Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting No-Recent-Activity This issue/PR is going stale and may be auto-closed without further activity.

Comments

@ministry-of-code
Copy link

Windows Terminal version (or Windows build number)

Terminal App Version 1.8.1521.0

Other Software

openssh on Linux WSL2 (Ubuntu)

Steps to reproduce

Sometimes, not always, the Terminal App crashes when I log off of a SSH connection to a remote (Linux) Server. I run WSL2 with Ubuntu Linux 4.19.84-microsoft-standard+ #1 SMP Fri Mar 19 11:33:09 CET 2021 x86_64 x86_64 x86_64 GNU/Linux.

This is really really a showstopper for my productive work. I have many tabs and server connections open and when the terminal app crashes, all those connections and open files, etc are lost!

Expected Behavior

Terminal app does not crash

Actual Behavior

Terminal app crashes

@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Jul 14, 2021
@zadjii-msft
Copy link
Member

Could you repro this with the Feedback hub? That'll get us a stack trace we can use to root-cause this

/feedback

@ghost
Copy link

ghost commented Jul 14, 2021

Hi there!

Can you please send us feedback with the Feedback Hub with this issue and paste the link here so we can more easily find your crash information on the back end?

Thanks!

image image

@ghost ghost added Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something Needs-Attention The core contributors need to come back around and look at this ASAP. and removed Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something labels Jul 14, 2021
@ministry-of-code
Copy link
Author

Could you repro this with the Feedback hub? That'll get us a stack trace we can use to root-cause this

/feedback

@zadjii-msft thanks for the feedback. I have submitted an issue via the Feedback hub two weeks ago:

https://aka.ms/AAd71do

Does this help?

@zadjii-msft
Copy link
Member

Oh no, just open the feedback hub and draft up the feedback, then the last step will ask you for a recording of the issue. Start the recording, then switch over to the Terminal and repro the bug, then switch back and end the recording. The Feedback Hub will automatically collect up the crash that happened during the recording and link it with the feedback. Submit the feedback, and share the aka.ms URL here, and we can then go look up the crash on the backend. Neat!

@zadjii-msft zadjii-msft added Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something and removed Needs-Attention The core contributors need to come back around and look at this ASAP. labels Jul 14, 2021
@zadjii-msft
Copy link
Member

(unfortunately, the original feedback you filed didn't collect up the crash, so it doesn't have anything helpful in it 😢)

@ministry-of-code
Copy link
Author

Ok, I understand. Unfortunately, I can not start the diagnose process in the Feedback hub app. When I try to start it for the windows-terminal app, I get an error message telling me that it did not work and I should try it again:

image

@ghost ghost added Needs-Attention The core contributors need to come back around and look at this ASAP. and removed Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something labels Jul 14, 2021
@WSLUser
Copy link
Contributor

WSLUser commented Jul 14, 2021

To ensure WSL2 isn't involved, are you using the default kernel or a custom one? If it's custom, what's different from the default WSL2 kernel? Technically this shouldn't matter unless something with the console options was changed or possibly even network config since ssh is involved.

@ministry-of-code
Copy link
Author

To ensure WSL2 isn't involved, are you using the default kernel or a custom one? If it's custom, what's different from the default WSL2 kernel? Technically this shouldn't matter unless something with the console options was changed or possibly even network config since ssh is involved.

You're right, I am using a custom WSL2 Kernel Configuration (based on the official MS WSL2-Kernel). I can't remember why I did this (it's a couple of months ago that I compiled it) - but it must have had an important reason - probably to fix a network related problem (docker, localhost forwarding or such). I will disable the custom kernel and use the official one again and see if this solves the crash or not and will come back in a few days to report.

@zadjii-msft zadjii-msft added Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something and removed Needs-Attention The core contributors need to come back around and look at this ASAP. labels Jul 15, 2021
@WSLUser
Copy link
Contributor

WSLUser commented Jul 15, 2021

FWIW I tested this on my custom kernel and has no issues. I'm also running 1.10 Preview now but I never had issues before that I could recall. My custom kernel is compiled from the 5.12 stable with the MS specific patches merged and my config options, which do enable some networking stuff, particularly for docker/kind/k3d, etc.

I'd still recommend testing with default 5.10.x kernel from WSL2 repo to reduce the factors.

@ghost ghost added the No-Recent-Activity This issue/PR is going stale and may be auto-closed without further activity. label Jul 19, 2021
@ghost
Copy link

ghost commented Jul 19, 2021

This issue has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 4 days. It will be closed if no further activity occurs within 3 days of this comment.

@ghost ghost closed this as completed Jul 22, 2021
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting No-Recent-Activity This issue/PR is going stale and may be auto-closed without further activity.
Projects
None yet
Development

No branches or pull requests

3 participants