Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Saving SETTINGS.JSON starts 11 processes #10163

Closed
vefatica opened this issue May 24, 2021 · 5 comments
Closed

Saving SETTINGS.JSON starts 11 processes #10163

vefatica opened this issue May 24, 2021 · 5 comments
Labels
Area-Settings Issues related to settings and customizability, for console or terminal Help Wanted We encourage anyone to jump in on these. Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Priority-3 A description (P3) Product-Terminal The new Windows Terminal.

Comments

@vefatica
Copy link

Windows Terminal version (or Windows build number)

Microsoft Windows 10 Pro for Workstations 10.0.19042.985 (2009, 20H2) WindowsTerminal: 1.8.1092.0

Other Software

No response

Steps to reproduce

With none of the WSL-related services running, open SETTINGS.JSON vie the settings UI and save it, noting the time.

Observe the processes that were started at that time.

Expected Behavior

Saving SETTINGS.JSON should not cause new processes to start.

Actual Behavior

I saved the file at 11:53:21 and got

Start  Time            Pid       CPU(s)     WS(M)  Name
--------------------------------------------------------------------------------
05/24  11:53:21.392  10204        0.156      12.4  LxssManager             LxssManager
05/24  11:53:21.439   6980        0.016      10.9  vmcompute               Hyper-V Host Compute Service
05/24  11:53:21.587   5088        0.078      12.9  hns                     Host Network Service
05/24  11:53:21.604   5204        0.078       7.5  nvagent                 Network Virtualization Service
05/24  11:53:21.622   7548        0.031      18.8  SharedAccess            Internet Connection Sharing (ICS)
05/24  11:53:21.666   9552        0.125       6.7  NetSetupSvc             NetSetupSvc
05/24  11:53:21.457   9376        0.125      19.3  vmwp.exe
05/24  11:53:21.478   3556        0.531     418.0  vmmem
05/24  11:53:22.215  10188        0.016       4.8  wslhost.exe
05/24  11:53:22.222   8164        0.000      10.9  conhost.exe
05/24  11:53:22.235   3612        0.016       8.8  dllhost.exe

That does not happen when I start WindowsTerminal, possibly because I have "Windows.Terminal.Wsl" among "disabledProfileSources". My guess is that it need not happen when the settings are reloaded.

@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels May 24, 2021
@zadjii-msft
Copy link
Member

Huh. Weird that we'd boot WSL even if it is disabled. We probably shouldn't do that.

@zadjii-msft zadjii-msft added Area-Settings Issues related to settings and customizability, for console or terminal Help Wanted We encourage anyone to jump in on these. Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-3 A description (P3) Product-Terminal The new Windows Terminal. labels May 24, 2021
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label May 24, 2021
@zadjii-msft zadjii-msft added this to the Terminal Backlog milestone May 24, 2021
@vefatica
Copy link
Author

Hmmm! Apparently it's happening when the startingDirectory path in my user-defined Ubuntu profile is validated. It doesn't happen if I comment out the startingDirectory. Does it have to do that?

"startingDirectory": "\\\\wsl$\\Ubuntu\\home\\vefatica"

@DHowett
Copy link
Member

DHowett commented May 24, 2021

Fortunately, I think we just removed the code that does that.

@zadjii-msft
Copy link
Member

Oh good catch! Turns out, it won't anymore! See #10045. We're gonna stop doing that in 1.9.

@zadjii-msft zadjii-msft removed this from the Terminal Backlog milestone May 24, 2021
@vefatica
Copy link
Author

That sounds good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Settings Issues related to settings and customizability, for console or terminal Help Wanted We encourage anyone to jump in on these. Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Priority-3 A description (P3) Product-Terminal The new Windows Terminal.
Projects
None yet
Development

No branches or pull requests

3 participants