From a0a70cc801c2e82b387ee0fb40226efe9bb4a8a6 Mon Sep 17 00:00:00 2001 From: PankajBhojwani Date: Wed, 21 Oct 2020 15:37:58 -0400 Subject: [PATCH] Fix slowdown on open/close tabs when the user has many profiles (#7993) ## Summary of the Pull Request Just deleting an unnecessary call to `_UpdateCommandsForPalette` **Note:** This only fixes slowdown when opening/closing a tab, but not upon first startup (we still need to call `_UpdateCommandsForPalette` there ## References Fixes the slowdown described in #7820 for opening and closing tabs, but doesn't improve startup time dramatically. ## Validation Steps Performed Tested with ~100 profiles in my settings file (cherry picked from commit 895ac06dbd75ea50772da5485c14b4f7d6c188ba) --- src/cascadia/TerminalApp/TerminalPage.cpp | 4 ---- 1 file changed, 4 deletions(-) diff --git a/src/cascadia/TerminalApp/TerminalPage.cpp b/src/cascadia/TerminalApp/TerminalPage.cpp index 91b0f40e455..86e9e4e7a24 100644 --- a/src/cascadia/TerminalApp/TerminalPage.cpp +++ b/src/cascadia/TerminalApp/TerminalPage.cpp @@ -1926,10 +1926,6 @@ namespace winrt::TerminalApp::implementation _rearrangeTo = eventArgs.Index(); } } - else - { - _UpdateCommandsForPalette(); - } _UpdateTabView(); }