From 5330759c0f3d98b92209813c48e781a664fe22eb Mon Sep 17 00:00:00 2001 From: Marcel Wagner Date: Fri, 4 Sep 2020 22:00:40 +0200 Subject: [PATCH] Update to a newer MUX prerelease; remove workaround for compact sizing (#7447) Update the WinUI version which allows us to remove the workaround. Closes #6681 --- src/cascadia/CascadiaPackage/CascadiaPackage.wapproj | 4 ++-- .../TerminalApp.LocalTests.vcxproj | 4 ++-- .../TestHostApp/TestHostApp.vcxproj | 2 +- src/cascadia/TerminalApp/TerminalAppLib.vcxproj | 4 ++-- src/cascadia/TerminalApp/TerminalPage.cpp | 10 ---------- src/cascadia/TerminalApp/dll/TerminalApp.vcxproj | 4 ++-- src/cascadia/TerminalApp/packages.config | 2 +- src/cascadia/WindowsTerminal/WindowsTerminal.vcxproj | 4 ++-- src/cascadia/WindowsTerminal/packages.config | 2 +- .../WindowsTerminalUniversal.vcxproj | 4 ++-- src/cascadia/ut_app/TerminalApp.UnitTests.vcxproj | 2 +- 11 files changed, 16 insertions(+), 26 deletions(-) diff --git a/src/cascadia/CascadiaPackage/CascadiaPackage.wapproj b/src/cascadia/CascadiaPackage/CascadiaPackage.wapproj index 237963a6428..3956e256859 100644 --- a/src/cascadia/CascadiaPackage/CascadiaPackage.wapproj +++ b/src/cascadia/CascadiaPackage/CascadiaPackage.wapproj @@ -147,12 +147,12 @@ - + This project references NuGet package(s) that are missing on this computer. Use NuGet Package Restore to download them. For more information, see http://go.microsoft.com/fwlink/?LinkID=322105. The missing file is {0}. - + diff --git a/src/cascadia/LocalTests_TerminalApp/TerminalApp.LocalTests.vcxproj b/src/cascadia/LocalTests_TerminalApp/TerminalApp.LocalTests.vcxproj index 67952867d7d..3bfbd065759 100644 --- a/src/cascadia/LocalTests_TerminalApp/TerminalApp.LocalTests.vcxproj +++ b/src/cascadia/LocalTests_TerminalApp/TerminalApp.LocalTests.vcxproj @@ -114,11 +114,11 @@ x86 $(Platform) - <_MUXBinRoot>"$(OpenConsoleDir)packages\Microsoft.UI.Xaml.2.5.0-prerelease.200609001\runtimes\win10-$(Native-Platform)\native\" + <_MUXBinRoot>"$(OpenConsoleDir)packages\Microsoft.UI.Xaml.2.5.0-prerelease.200812001\runtimes\win10-$(Native-Platform)\native\" - + diff --git a/src/cascadia/LocalTests_TerminalApp/TestHostApp/TestHostApp.vcxproj b/src/cascadia/LocalTests_TerminalApp/TestHostApp/TestHostApp.vcxproj index b6d85e9ae04..d335d47396b 100644 --- a/src/cascadia/LocalTests_TerminalApp/TestHostApp/TestHostApp.vcxproj +++ b/src/cascadia/LocalTests_TerminalApp/TestHostApp/TestHostApp.vcxproj @@ -121,7 +121,7 @@ - + diff --git a/src/cascadia/TerminalApp/TerminalAppLib.vcxproj b/src/cascadia/TerminalApp/TerminalAppLib.vcxproj index 85d3a858790..421f4dbadf1 100644 --- a/src/cascadia/TerminalApp/TerminalAppLib.vcxproj +++ b/src/cascadia/TerminalApp/TerminalAppLib.vcxproj @@ -355,13 +355,13 @@ - + This project references NuGet package(s) that are missing on this computer. Use NuGet Package Restore to download them. For more information, see http://go.microsoft.com/fwlink/?LinkID=322105. The missing file is {0}. - + diff --git a/src/cascadia/TerminalApp/TerminalPage.cpp b/src/cascadia/TerminalApp/TerminalPage.cpp index ceb86a52481..22aab3e6df5 100644 --- a/src/cascadia/TerminalApp/TerminalPage.cpp +++ b/src/cascadia/TerminalApp/TerminalPage.cpp @@ -713,16 +713,6 @@ namespace winrt::TerminalApp::implementation auto tabViewItem = newTabImpl->GetTabViewItem(); _tabView.TabItems().Append(tabViewItem); - // GH#6570 - // The TabView does not apply compact sizing to items added after Compact is enabled. - // By forcibly reapplying compact sizing every time we add a new tab, we'll make sure - // that it works. - // Workaround from https://github.com/microsoft/microsoft-ui-xaml/issues/2711 - if (_tabView.TabWidthMode() == MUX::Controls::TabViewWidthMode::Compact) - { - _tabView.UpdateLayout(); - _tabView.TabWidthMode(MUX::Controls::TabViewWidthMode::Compact); - } // Set this tab's icon to the icon from the user's profile const auto profile = _settings->FindProfile(profileGuid); diff --git a/src/cascadia/TerminalApp/dll/TerminalApp.vcxproj b/src/cascadia/TerminalApp/dll/TerminalApp.vcxproj index 8d8962cca79..49ccdf39099 100644 --- a/src/cascadia/TerminalApp/dll/TerminalApp.vcxproj +++ b/src/cascadia/TerminalApp/dll/TerminalApp.vcxproj @@ -78,13 +78,13 @@ - + This project references NuGet package(s) that are missing on this computer. Use NuGet Package Restore to download them. For more information, see http://go.microsoft.com/fwlink/?LinkID=322105. The missing file is {0}. - + diff --git a/src/cascadia/TerminalApp/packages.config b/src/cascadia/TerminalApp/packages.config index 1f023409c8d..ff1e310ee51 100644 --- a/src/cascadia/TerminalApp/packages.config +++ b/src/cascadia/TerminalApp/packages.config @@ -1,6 +1,6 @@  - + diff --git a/src/cascadia/WindowsTerminal/WindowsTerminal.vcxproj b/src/cascadia/WindowsTerminal/WindowsTerminal.vcxproj index 395c76d9e8e..358a5bfc457 100644 --- a/src/cascadia/WindowsTerminal/WindowsTerminal.vcxproj +++ b/src/cascadia/WindowsTerminal/WindowsTerminal.vcxproj @@ -94,14 +94,14 @@ - + This project references NuGet package(s) that are missing on this computer. Use NuGet Package Restore to download them. For more information, see http://go.microsoft.com/fwlink/?LinkID=322105. The missing file is {0}. - + diff --git a/src/cascadia/WindowsTerminal/packages.config b/src/cascadia/WindowsTerminal/packages.config index 166f8861ffa..797852c2795 100644 --- a/src/cascadia/WindowsTerminal/packages.config +++ b/src/cascadia/WindowsTerminal/packages.config @@ -2,7 +2,7 @@ - + \ No newline at end of file diff --git a/src/cascadia/WindowsTerminalUniversal/WindowsTerminalUniversal.vcxproj b/src/cascadia/WindowsTerminalUniversal/WindowsTerminalUniversal.vcxproj index 0a749357a56..35c303bd5d8 100644 --- a/src/cascadia/WindowsTerminalUniversal/WindowsTerminalUniversal.vcxproj +++ b/src/cascadia/WindowsTerminalUniversal/WindowsTerminalUniversal.vcxproj @@ -154,7 +154,7 @@ - + @@ -162,7 +162,7 @@ This project references NuGet package(s) that are missing on this computer. Use NuGet Package Restore to download them. For more information, see http://go.microsoft.com/fwlink/?LinkID=322105. The missing file is {0}. - + diff --git a/src/cascadia/ut_app/TerminalApp.UnitTests.vcxproj b/src/cascadia/ut_app/TerminalApp.UnitTests.vcxproj index 868002a5fd2..2bb6093e8e5 100644 --- a/src/cascadia/ut_app/TerminalApp.UnitTests.vcxproj +++ b/src/cascadia/ut_app/TerminalApp.UnitTests.vcxproj @@ -98,7 +98,7 @@ x86 $(Platform) - <_MUXBinRoot>"$(OpenConsoleDir)packages\Microsoft.UI.Xaml.2.5.0-prerelease.200609001\runtimes\win10-$(Native-Platform)\native\" + <_MUXBinRoot>"$(OpenConsoleDir)packages\Microsoft.UI.Xaml.2.5.0-prerelease.200812001\runtimes\win10-$(Native-Platform)\native\"