Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle filename collisions in validation #523

Closed
pownkel opened this issue Mar 7, 2024 · 1 comment
Closed

Handle filename collisions in validation #523

pownkel opened this issue Mar 7, 2024 · 1 comment
Labels
accepted We are working on this and hope to release it into the product

Comments

@pownkel
Copy link
Contributor

pownkel commented Mar 7, 2024

Linux filesystems are case-sensitive, but Windows filesystems are not, and the SBOM validator follows the case sensitivity of whichever filesystem it runs on. As a result, if an SBOM is generated on Linux and contains files called, for example, filename and FileName, and we attempt to validate that SBOM on Windows, the validator tool sees the same filename twice with different hashes.

Currently if this happens, we add null to a dictionary of file hashes, but since we do not check for null when that dictionary is used, the user sees the message Object reference not set to an instance of an object, which doesn't give any clues about what happened.

When this happens, we should output a more meaningful error, ideally one prompting the user to make sure the validator runs on the same OS that the SBOM was generated on.

@pownkel pownkel added the needs triage Default status upon issue submission label Mar 8, 2024
@jalkire jalkire added accepted We are working on this and hope to release it into the product and removed needs triage Default status upon issue submission labels Mar 28, 2024
@DaveTryon
Copy link
Contributor

This has been merged to main and will be included in our next release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted We are working on this and hope to release it into the product
Projects
None yet
Development

No branches or pull requests

3 participants