[heft-jest] Fix node-modules-symlink-resolver #5013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmichon-msft
requested review from
iclanton,
octogonz,
apostolisms and
D4N14L
as code owners
iclanton
approved these changes
Nov 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
For Jest, specifically, the
realpathSyncfunction inside ofjest-resolveis supposed to return the input path if part of the path does not exist.Details
Since
jest-resolve'srealpathSyncinternally callsjest-util'stryRealpathSync, and the latter is already overridden, this PR just removes the separate override in jest-resolve in favor of relying ontryRealpathSyncbeing overridden centrally.Note that this ends up caching all the paths twice, but that's less of a concern than the syscalls this feature is avoiding.
How it was tested
Local test invocation.
Impacted documentation
None