From 289fdc73d383338a4ab00dd3d5c62f75a483c182 Mon Sep 17 00:00:00 2001 From: Ian Clanton-Thuon Date: Fri, 15 Sep 2023 01:05:41 -0700 Subject: [PATCH 1/2] Drop support for Node 14. --- .github/workflows/ci.yml | 2 +- common/config/azure-pipelines/ci.yaml | 4 ++-- common/config/azure-pipelines/templates/install-node.yaml | 2 +- rush.json | 2 +- 4 files changed, 5 insertions(+), 5 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 26e7208e32b..97a28e4041d 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -11,7 +11,7 @@ jobs: strategy: matrix: include: - - NodeVersion: 14 + - NodeVersion: 16 OS: ubuntu-latest - NodeVersion: 18 OS: ubuntu-latest diff --git a/common/config/azure-pipelines/ci.yaml b/common/config/azure-pipelines/ci.yaml index 8bbf419e6b7..ee11676b233 100644 --- a/common/config/azure-pipelines/ci.yaml +++ b/common/config/azure-pipelines/ci.yaml @@ -7,10 +7,10 @@ jobs: condition: succeeded() strategy: matrix: - 'NodeJs 14': - NodeMajorVersion: 14 'NodeJs 16': NodeMajorVersion: 16 + 'NodeJs 18': + NodeMajorVersion: 18 steps: - checkout: self diff --git a/common/config/azure-pipelines/templates/install-node.yaml b/common/config/azure-pipelines/templates/install-node.yaml index 9b22e47f6e2..d3e16755fc3 100644 --- a/common/config/azure-pipelines/templates/install-node.yaml +++ b/common/config/azure-pipelines/templates/install-node.yaml @@ -1,7 +1,7 @@ parameters: - name: NodeMajorVersion type: number - default: 14 + default: 18 steps: - task: NodeTool@0 diff --git a/rush.json b/rush.json index 5b45c84c180..a36828f9510 100644 --- a/rush.json +++ b/rush.json @@ -42,7 +42,7 @@ * LTS schedule: https://nodejs.org/en/about/releases/ * LTS versions: https://nodejs.org/en/download/releases/ */ - "nodeSupportedVersionRange": ">=14.15.0 <15.0.0 || >=16.13.0 <17.0.0 || >=18.15.0 <19.0.0", + "nodeSupportedVersionRange": ">=16.13.0 <17.0.0 || >=18.15.0 <19.0.0", /** * If the version check above fails, Rush will display a message showing the current From f82ec0252fdc55e8e10d5bb0b6dba4e5112cea77 Mon Sep 17 00:00:00 2001 From: Ian Clanton-Thuon Date: Fri, 15 Sep 2023 01:10:44 -0700 Subject: [PATCH 2/2] Remove the AzDO CI pipeline YAML. --- common/config/azure-pipelines/ci.yaml | 20 -------------------- 1 file changed, 20 deletions(-) delete mode 100644 common/config/azure-pipelines/ci.yaml diff --git a/common/config/azure-pipelines/ci.yaml b/common/config/azure-pipelines/ci.yaml deleted file mode 100644 index ee11676b233..00000000000 --- a/common/config/azure-pipelines/ci.yaml +++ /dev/null @@ -1,20 +0,0 @@ -pool: - vmImage: 'ubuntu-latest' -variables: - FORCE_COLOR: 1 -jobs: - - job: PRBuild - condition: succeeded() - strategy: - matrix: - 'NodeJs 16': - NodeMajorVersion: 16 - 'NodeJs 18': - NodeMajorVersion: 18 - - steps: - - checkout: self - - template: templates/install-node.yaml - parameters: - NodeMajorVersion: ${{ NodeMajorVersion }} - - template: templates/build.yaml