-
Notifications
You must be signed in to change notification settings - Fork 848
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add telemetry to application insights #708
Comments
YARP operates as an ASP.NET Core component. What do you need from YARP beyond Application Insights' existing ASP.NET Core integration? |
The application insights log doens't show the proxy request For example, my proxy calls an api to get a valid token for this request, if I open the application insights log, it show the token request, but it doesn't show the proxy request to the destination. Maybe I did something wrong in the telemetry configuration services.AddReverseProxy()
.LoadFromConfig(Configuration.GetSection("ReverseProxy"));
services.AddTelemetryListeners();
services.AddApplicationInsightsTelemetry(Configuration["APPINSIGHTS_CONNECTIONSTRING"]); |
@MihaZupan do you think this is because of dotnet/runtime#31261? |
Triage: We will need some guidance/docs by @MihaZupan |
I didn't understand @karelz and @MihaZupan , is there something that I can do to log all of the information about the proxy information on the fowarded request? |
Not currently, we will need to add more instrumentation as described in #776 (comment) to support AppInsights out of the box. Out-of-the-box you will currently only see the incoming requests to the proxy, and we will forward the trace information in the request to the backend, so if you have other services participating in the distributed trace, those will light up as well. |
Thanks, if it doesn't work out of the box, is there something that I can do? some extension would help? I could try to develop something if I had the direction |
Is there any update to this? I'd also like to know if there's anything we can do now to light up dependency tracking of proxied requests in AppInsights. |
It is actively being worked on in runtime. Relevant issue: dotnet/runtime#50658 If you are blocked, see outgoing dependencies tracking docs on how you could instrument your handler. |
Stepping back a bit here, are you looking for distributed tracing - which is what most of this thread is about, or other logging from the proxy being consumed by app-insights? |
For me, I'm looking for dependency tracing. I want to be able to go into App Insights in the proxy, and see the proxied requests, see what database calls were made in the backend, etc. We can normally do that with our other App Services, but for some reason the proxy isn't doing this at all. |
I believe all distributed tracing needs can be addressed via the I recommend we remove the Do we care about enhancing Removing the milestone to bring this to attention in next triage. |
Is this fixable for 1.0? |
Yes, the default I had in mind specifically was
Default runtime behavior (at least for now) is closer to |
Folks affected by this: Is it possible for you to migrate to .NET 6.0 where this is solved? |
Triage: Some docs may be still needed -- @MihaZupan to check it out, then close. |
Note: |
It may make sense to be a 1.1 feature to go with .NET 6? |
Yarp RC1 no longer includes the |
What should we add or change to make your life better?
Would be interesting to make integtation with application insights easier, like adding all the telemetry to azure application inghts
Why is this important to you?
Because we can use all of the appliction insights infrastructure to monitor the proxy.
The text was updated successfully, but these errors were encountered: