Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate too low perf gain from NonValidated headers API #1083

Closed
alnikola opened this issue Jun 14, 2021 · 0 comments · Fixed by #1507
Closed

Investigate too low perf gain from NonValidated headers API #1083

alnikola opened this issue Jun 14, 2021 · 0 comments · Fixed by #1507
Assignees
Labels
tenet-performance Impacting performance Type: Idea This issue is a high-level idea for discussion.

Comments

@alnikola
Copy link
Contributor

We switched YARP header processing to the new HttpHeaders.NonValidated API and measured how RPS changes. RPS grew up but only by 2% whereas in the previous experiments with a reflection based approach to non-validated headers enumeration the 7% RPS increase was observed. We need to investigate why there is such big difference between the expected increase (7%) and the actual increase (2%).

@alnikola alnikola added the Type: Idea This issue is a high-level idea for discussion. label Jun 14, 2021
@karelz karelz added this to the Backlog milestone Jun 17, 2021
@karelz karelz added the tenet-performance Impacting performance label Jun 17, 2021
@Tratcher Tratcher modified the milestones: Backlog, YARP 1.1.0 Nov 12, 2021
@MihaZupan MihaZupan self-assigned this Dec 14, 2021
@karelz karelz modified the milestones: YARP 1.1.0, Backlog Dec 16, 2021
@MihaZupan MihaZupan modified the milestones: Backlog, YARP 1.1.0 Jan 10, 2022
@MihaZupan MihaZupan modified the milestones: YARP 1.1.0, YARP 1.1.0-RC1 Mar 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tenet-performance Impacting performance Type: Idea This issue is a high-level idea for discussion.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants