Run clippy in binding tests

Signed-off-by: Anand Krishnamoorthi <[email protected]>

.github/workflows/test-ffi.yml

@@ -0,0 +1,22 @@
+name: bindings/c-cpp
+
+on:
+  push:
+    branches: [ "main" ]
+  pull_request:
+    branches: [ "main" ]
+
+jobs:
+  test:
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout repository
+        uses: actions/checkout@v4
+        with:
+          fetch-depth: 0
+
+      - name: Test FFI
+        run: |
+          cargo build -r
+          cargo clippy --all-targets --no-deps -- -Dwarnings
+        working-directory: ./bindings/ffi

.github/workflows/test-java.yml

@@ -22,7 +22,9 @@ jobs:
       - uses: dtolnay/rust-toolchain@stable
 
       - name: Building binding
-        run: cargo build --release --manifest-path bindings/java/Cargo.toml
+        run: |
+          cargo clippy --all-targets --no-deps -- -Dwarnings
+          cargo build --release --manifest-path bindings/java/Cargo.toml
 
       - name: Build jar
         run: mvn package

.github/workflows/test-python.yml

@@ -34,4 +34,5 @@ jobs:
         run:  |
           pip3 install dist/regorus-*.whl
           cd bindings/python
+          cargo clippy --all-targets --no-deps -- -Dwarnings
           python3 test.py          

.github/workflows/test-ruby.yml

@@ -27,4 +27,5 @@ jobs:
       - name: Run ruby tests
         run:  |
           cd bindings/ruby
+          cargo clippy --all-targets --no-deps -- -Dwarnings
           bundle exec rake

.github/workflows/test-wasm.yml

@@ -26,6 +26,7 @@ jobs:
       - name: Test wasm binding
         run: |
           cd bindings/wasm
+          cargo clippy --all-targets --no-deps -- -Dwarnings
           wasm-pack build --target nodejs --release
           wasm-pack test --release --node
           node test.js

bindings/ffi/Cargo.toml

@@ -13,8 +13,9 @@ regorus = { path  = "../..", default-features = false }
 serde_json = "1.0.113"
 
 [features]
-default = ["std", "regorus/arc", "regorus/full-opa"]
+default = ["std", "coverage", "regorus/arc", "regorus/full-opa"]
 std = ["regorus/std"]
+coverage = ["regorus/coverage"]
 custom_allocator = []
 
 [build-dependencies]

bindings/ffi/src/lib.rs

@@ -130,7 +130,7 @@ pub extern "C" fn regorus_engine_clone(engine: *mut RegorusEngine) -> *mut Regor
 
 #[no_mangle]
 pub extern "C" fn regorus_engine_drop(engine: *mut RegorusEngine) {
-    if let Ok(ref mut e) = to_ref(&engine) {
+    if let Ok(e) = to_ref(&engine) {
         unsafe {
             let _ = Box::from_raw(e);
         }
@@ -308,6 +308,7 @@ pub extern "C" fn regorus_engine_eval_rule(
 /// See https://docs.rs/regorus/0.1.0-alpha.2/regorus/struct.Engine.html#method.set_enable_coverage
 /// * `enable`: Whether to enable or disable coverage.
 #[no_mangle]
+#[cfg(feature = "coverage")]
 pub extern "C" fn regorus_engine_set_enable_coverage(
     engine: *mut RegorusEngine,
     enable: bool,
@@ -322,6 +323,7 @@ pub extern "C" fn regorus_engine_set_enable_coverage(
 ///
 /// See https://docs.rs/regorus/0.1.0-alpha.2/regorus/struct.Engine.html#method.get_coverage_report
 #[no_mangle]
+#[cfg(feature = "coverage")]
 pub extern "C" fn regorus_engine_get_coverage_report(engine: *mut RegorusEngine) -> RegorusResult {
     let output = || -> Result<String> {
         Ok(serde_json::to_string_pretty(
@@ -342,6 +344,7 @@ pub extern "C" fn regorus_engine_get_coverage_report(engine: *mut RegorusEngine)
 ///
 /// See https://docs.rs/regorus/latest/regorus/coverage/struct.Report.html#method.to_string_pretty
 #[no_mangle]
+#[cfg(feature = "coverage")]
 pub extern "C" fn regorus_engine_get_coverage_report_pretty(
     engine: *mut RegorusEngine,
 ) -> RegorusResult {
@@ -365,6 +368,7 @@ pub extern "C" fn regorus_engine_get_coverage_report_pretty(
 ///
 /// See https://docs.rs/regorus/0.1.0-alpha.2/regorus/struct.Engine.html#method.clear_coverage_data
 #[no_mangle]
+#[cfg(feature = "coverage")]
 pub extern "C" fn regorus_engine_clear_coverage_data(engine: *mut RegorusEngine) -> RegorusResult {
     to_regorus_result(|| -> Result<()> {
         to_ref(&engine)?.engine.clear_coverage_data();

bindings/python/src/lib.rs

@@ -317,7 +317,7 @@ impl Engine {
         serde_json::to_string_pretty(&report).map_err(|e| anyhow!("{e}"))
     }
 
-    // Get coverage report as pretty printable string.
+    /// Get coverage report as pretty printable string.
     ///
     pub fn get_coverage_report_pretty(&self) -> Result<String> {
         self.engine.get_coverage_report()?.to_string_pretty()

bindings/ruby/ext/regorusrb/src/lib.rs

@@ -72,7 +72,7 @@ impl Engine {
     }
 
     fn add_data_from_json_file(&self, path: String) -> Result<(), Error> {
-        let json_data = regorus::Value::from_json_file(&path).map_err(|e| {
+        let json_data = regorus::Value::from_json_file(path).map_err(|e| {
             Error::new(
                 runtime_error(),
                 format!("Failed to parse JSON data file: {}", e),
@@ -112,7 +112,7 @@ impl Engine {
     }
 
     fn add_input_from_json_file(&self, path: String) -> Result<(), Error> {
-        let json_data = regorus::Value::from_json_file(&path).map_err(|e| {
+        let json_data = regorus::Value::from_json_file(path).map_err(|e| {
             Error::new(
                 runtime_error(),
                 format!("Failed to parse JSON input file: {}", e),
@@ -193,7 +193,8 @@ impl Engine {
     }
 
     fn set_enable_coverage(&self, enable: bool) -> Result<(), Error> {
-        Ok(self.engine.borrow_mut().set_enable_coverage(enable))
+        self.engine.borrow_mut().set_enable_coverage(enable);
+        Ok(())
     }
 
     fn get_coverage_report_as_json(&self) -> Result<String, Error> {
@@ -237,12 +238,14 @@ impl Engine {
     }
 
     fn clear_coverage_data(&self) -> Result<(), Error> {
-        Ok(self.engine.borrow_mut().clear_coverage_data())
+        self.engine.borrow_mut().clear_coverage_data();
+        Ok(())
     }
 
     // Print statements can be gathered async instead of printing to stderr
     fn set_gather_prints(&self, enable: bool) -> Result<(), Error> {
-        Ok(self.engine.borrow_mut().set_gather_prints(enable))
+        self.engine.borrow_mut().set_gather_prints(enable);
+        Ok(())
     }
 
     fn take_prints(&self) -> Result<Vec<String>, Error> {