Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement a more flexible filtering mechanism for inclusions/exclusions of types. #99

Open
nichamp opened this issue Jun 16, 2021 · 0 comments
Labels
enhancement New feature or request

Comments

@nichamp
Copy link
Collaborator

nichamp commented Jun 16, 2021

It would be nice if filtering improvements could be made to support regular expressions or a better scheme if one exists instead of the current prefix matching as it can be inconvenient to include a minimal set of projections and these can quickly become incorrect if new types or nested namespaces are added later.

There is also the complexity around filtering interfaces since they are named differently than their corresponding class (though thankfully it is no longer necessary to name the factory or static interfaces too) such as including IConnectionProfile and ConnectionProfile below. In the example, I also explicitly don't want the newer IConnectionProfile interfaces as they aren't relevant to my scenario and I am attempting to minimize footprint.

For example, to include:

Windows::Networking::Connectivity::ConnectionCost
Windows::Networking::Connectivity::ConnectionProfile
Windows::Networking::Connectivity::NetworkInformation
Windows::Networking::Connectivity::NetworkConnectivityLevel
Windows::Networking::Connectivity::NetworkCostType

I have to do:

-include Windows.Networking.Connectivity.ConnectionCost
-include Windows.Networking.Connectivity.ConnectionProfile
-exclude Windows.Networking.Connectivity.IConnectionProfile2
-exclude Windows.Networking.Connectivity.IConnectionProfile3
-exclude Windows.Networking.Connectivity.IConnectionProfile4
-exclude Windows.Networking.Connectivity.IConnectionProfile5
-exclude Windows.Networking.Connectivity.ConnectionProfileDeleteStatus
-exclude Windows.Networking.Connectivity.ConnectionProfileFilter
-include Windows.Networking.Connectivity.IConnectionProfile
-exclude Windows.Networking.Connectivity.IConnectionProfileFilter
-include Windows.Networking.Connectivity.NetworkInformation
-include Windows.Networking.Connectivity.NetworkStatusChangedEventHandler
-include Windows.Networking.Connectivity.NetworkConnectivityLevel
-include Windows.Networking.Connectivity.NetworkCostType
@nichamp nichamp added the enhancement New feature or request label Jun 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant